MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

not used pooling arguments

Open MOLOjl opened this issue 4 years ago • 2 comments

hi, I was using a pooling kernel, I notice there are some not used arguments in forward and backward functions, as in below:

miopenStatus_t PoolingDescriptor::Forward(Handle& handle,
                                          const void* alpha,
                                          const TensorDescriptor& xDesc,
                                          ConstData_t x,
                                          const void* beta,
                                          const TensorDescriptor& yDesc,
                                          Data_t y,
                                          bool save_index,
                                          Data_t workSpace,
                                          size_t /*workSpaceSize*/);

miopenStatus_t PoolingDescriptor::Backward(Handle& handle,
                                           const void* alpha,
                                           const TensorDescriptor& yDesc,
                                           ConstData_t /*y*/,
                                           const TensorDescriptor& dyDesc,
                                           ConstData_t dy,
                                           const TensorDescriptor& xDesc,
                                           ConstData_t /*x*/,
                                           const void* beta,
                                           const TensorDescriptor& dxDesc,
                                           Data_t dx,
                                           ConstData_t workSpace);

why not delete them, it can be very confusing if I haven't read your source code. by the way, if I input some null value when using these functions, will they cause errors?

MOLOjl avatar Dec 22 '21 07:12 MOLOjl

You may use 0s/nullptrs for those, that should not pose any problem. API change is sadly not as simple to implement as many people would like, including me.

DrizztDoUrden avatar Dec 28 '21 10:12 DrizztDoUrden

@MOLOjl Do you still need assistance with this issue? It not, please close ticket. Thanks!

ppanchad-amd avatar Apr 15 '24 20:04 ppanchad-amd