MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

[ImplicitGemm] Revise workarounds

Open atamazov opened this issue 3 years ago • 3 comments

I guess it's time to find out if these W/A are still necessary in 4.3.1 (which we currently run CI on) and disable them.

This is the key point for killing the workarounds in the future and cleaning up the code. For example, if some W/A is not needed since, say, 4.3.1, then we can get rid of it as soon as we discontinue support for 4.3.

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/36807f4653b1634a483160d8cb78c81b4d9f6e27/src/include/miopen/solver/implicitgemm_util.hpp#L43-L55

atamazov avatar Nov 04 '21 17:11 atamazov

CC: @aserio great starter for the round robin game: how many W/As can you eliminate this week? :)

junliume avatar Nov 07 '21 09:11 junliume

@aserio Is this fixed with latest ROCm 6.0.2 (HIP 6.0.32831)? Thanks!

ppanchad-amd avatar Apr 15 '24 18:04 ppanchad-amd

@ppanchad-amd, I would assume that this was not completed as the issue is still open. @atamazov, do you know if this work was completed?

aserio avatar Apr 15 '24 18:04 aserio