AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

`generic_float` for Float8E8M0

Open CharlieL7 opened this issue 2 months ago • 1 comments

Motivation

  • Introduce Float8E8M0 type within MIGraphX for better MXFP4 optimizations and to use hipblaslt mxfp4 kernels.

Technical Details

Changelog Category

    • [ ] Added: New functionality.
    • [ ] Changed: Changes to existing functionality.
    • [ ] Removed: Functionality or support that has been removed. (Compared to a previous release)
    • [ ] Optimized: Component performance that has been optimized or improved.
    • [ ] Resolved Issues: Known issues from a previous version that have been resolved.
    • [ ] Not Applicable: This PR is not to be included in the changelog.

CharlieL7 avatar Oct 23 '25 21:10 CharlieL7

So far so good - Tidy seems a bit heavy handed here and CI is giving a nonsensical error for some reason across builds

[2025-10-23T22:49:15.868Z] /var/jenkins/workspace/AMDMIGraphX_PR-4403/src/targets/gpu/hip_gemm_impl.cpp:77:5: error: label at end of compound statement is a C++23 extension [-Werror,-Wc++23-extensions]

[2025-10-23T22:49:15.868Z]    77 |     }

[2025-10-23T22:49:15.868Z]       |     ^

[2025-10-23T22:49:15.868Z] 1 error generated.

[2025-10-23T22:49:15.868Z] make[2]: *** [src/targets/gpu/CMakeFiles/migraphx_gpu.dir/build.make:370: src/targets/gpu/CMakeFiles/migraphx_gpu.dir/hip_gemm_impl.cpp.o] Error 1

[2025-10-23T22:49:15.868Z] make[2]: *** Waiting for unfinished jobs....

[2025-10-23T22:49:15.868Z] /var/jenkins/workspace/AMDMIGraphX_PR-4403/src/targets/gpu/gemm_impl.cpp:79:5: error: label at end of compound statement is a C++23 extension [-Werror,-Wc++23-extensions]

[2025-10-23T22:49:15.868Z]    79 |     }

[2025-10-23T22:49:15.868Z]       |     ^

[2025-10-23T22:49:15.868Z] 1 error generated.

[2025-10-23T22:49:15.868Z] make[2]: *** [src/targets/gpu/CMakeFiles/migraphx_gpu.dir/build.make:328: src/targets/gpu/CMakeFiles/migraphx_gpu.dir/gemm_impl.cpp.o] Error 1

[2025-10-23T22:49:30.250Z] make[2]: Leaving directory '/var/jenkins/workspace/AMDMIGraphX_PR-4403/build'

[2025-10-23T22:49:30.251Z] make[1]: *** [CMakeFiles/Makefile2:21332: src/targets/gpu/CMakeFiles/migraphx_gpu.dir/all] Error 2

[2025-10-23T22:49:30.251Z] make[1]: Leaving directory '/var/jenkins/workspace/AMDMIGraphX_PR-4403/build'

Let me know when you want me to look at this again and its ready for full review unless this needs to be taken out of draft. Not really issues with this right now if that's the case

TedThemistokleous avatar Oct 25 '25 02:10 TedThemistokleous