AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

unregistered operation 'migraphx.max' found in dialect ('migraphx')

Open shivadbhavsar opened this issue 1 year ago • 3 comments

MLIR attention does not seem to support the pointwise max operation, need to add check for it in the fuse_mlir pass.

Adjacent problem to #3439. Occurs when compiling the same model using mlir attention.

shivadbhavsar avatar Sep 25 '24 21:09 shivadbhavsar

We probably need to add this operator to mlir, but it still is probably good to check for supported pointwise before fusing attention.

pfultz2 avatar Sep 25 '24 21:09 pfultz2

Agreed, is that a change in migraphx or is that something mlir needs to support first?

shivadbhavsar avatar Sep 25 '24 22:09 shivadbhavsar

Its a change that needs to happen in mlir, but it should be simple to add.

pfultz2 avatar Sep 25 '24 22:09 pfultz2