AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Pooling Improvements

Open umangyadav opened this issue 1 year ago • 0 comments

  • [ ] ceil_mode in JIT pooling https://github.com/ROCm/AMDMIGraphX/issues/3356
  • [ ] dilations in JIT pooling
  • [ ] JIT pooling is not being tested in CI: https://github.com/ROCm/AMDMIGraphX/issues/3234

Problems with "rewrite_pooling" pass.

  • [ ] It doesn't handle LpPool case with dilation. Link1
  • [ ] it is doing gather on original input and not on the padded one. Link2
  • [ ] It doesn't handle pre and post padding. Link3

ONNX backend tests that are affected :

    backend_test.exclude(
        r'test_averagepool_3d_dilations_large_count_include_pad_is_0_ceil_mode_is_True_cpu'
    )
    backend_test.exclude(
        r'test_averagepool_3d_dilations_large_count_include_pad_is_1_ceil_mode_is_True_cpu'
    )
    backend_test.exclude(r'test_maxpool_2d_ceil_output_size_reduce_by_one_cpu')
    backend_test.exclude(r'test_maxpool_3d_dilations_use_ref_impl_large_cpu')

umangyadav avatar Aug 12 '24 19:08 umangyadav