AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Squeeze dyn dim allow compatible

Open CharlieL7 opened this issue 1 year ago • 3 comments

Allows squeeze to work on an axis with dynamic_dimension that intersects with {1, 1}. Needed to work with fully unknown dimensions {0, max_int}.

CharlieL7 avatar May 03 '24 14:05 CharlieL7

Test Batch Rate new
f327b0
Rate old
bc6c79
Diff Compare
torchvision-resnet50 64 2,958.51 2,950.97 0.26% :white_check_mark:
torchvision-resnet50_fp16 64 6,556.68 6,566.23 -0.15% :white_check_mark:
torchvision-densenet121 32 2,422.54 2,421.23 0.05% :white_check_mark:
torchvision-densenet121_fp16 32 3,959.92 3,992.03 -0.80% :white_check_mark:
torchvision-inceptionv3 32 1,658.40 1,659.26 -0.05% :white_check_mark:
torchvision-inceptionv3_fp16 32 2,597.23 2,598.65 -0.05% :white_check_mark:
cadene-inceptionv4 16 776.62 776.84 -0.03% :white_check_mark:
cadene-resnext64x4 16 740.46 740.86 -0.05% :white_check_mark:
slim-mobilenet 64 6,916.59 6,918.90 -0.03% :white_check_mark:
slim-nasnetalarge 64 177.12 177.18 -0.03% :white_check_mark:
slim-resnet50v2 64 2,875.51 2,876.68 -0.04% :white_check_mark:
bert-mrpc-onnx 8 1,063.27 1,064.43 -0.11% :white_check_mark:
bert-mrpc-tf 1 467.63 511.61 -8.60% :red_circle:
pytorch-examples-wlang-gru 1 428.73 371.38 15.44% :high_brightness:
pytorch-examples-wlang-lstm 1 549.72 409.57 34.22% :high_brightness:
torchvision-resnet50_1 1 776.83 790.15 -1.69% :white_check_mark:
cadene-dpn92_1 1 434.77 394.00 10.35% :high_brightness:
cadene-resnext101_1 1 366.66 362.65 1.10% :white_check_mark:
onnx-taau-downsample 1 348.78 349.17 -0.11% :white_check_mark:
dlrm-criteoterabyte 1 33.43 33.45 -0.07% :white_check_mark:
dlrm-criteoterabyte_fp16 1 56.65 56.69 -0.08% :white_check_mark:
agentmodel 1 7,538.98 7,460.35 1.05% :white_check_mark:
unet_fp16 2 57.44 57.31 0.22% :white_check_mark:
resnet50v1_fp16 1 968.60 869.63 11.38% :high_brightness:
resnet50v1_int8 1 833.17 823.61 1.16% :white_check_mark:
bert_base_cased_fp16 64 1,012.09 1,012.93 -0.08% :white_check_mark:
bert_large_uncased_fp16 32 316.58 316.62 -0.01% :white_check_mark:
bert_large_fp16 1 nan nan nan% :x:
distilgpt2_fp16 16 1,993.11 1,994.48 -0.07% :white_check_mark:
yolov5s 1 506.34 501.26 1.01% :white_check_mark:
tinyllama 1 44.97 44.99 -0.05% :white_check_mark:
vicuna-fastchat 1 175.15 178.18 -1.70% :white_check_mark:
whisper-tiny-encoder 1 404.87 404.60 0.07% :white_check_mark:
whisper-tiny-decoder 1 427.98 424.85 0.74% :white_check_mark:

This build is not recommended to merge :red_circle:

migraphx-bot avatar May 03 '24 17:05 migraphx-bot


:x:bert-mrpc-onnx: ERROR - check error outputTraceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 340, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 205, in main
model = migraphx.parse_onnx(model_name, default_dim_value=batch)
RuntimeError: /src/AMDMIGraphX/src/onnx/onnx_parser.cpp:264: parse_from: PARSE_FROM: Failed reading onnx file: /new-saved-models/huggingface-transformers/bert_mrpc1.onnx

     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
:x:cadene-resnext101_1: ERROR - check error output2024-05-09 14:39:25.652978106 [W:onnxruntime:, model.cc:183 Model] ONNX Runtime only guarantees support for models stamped with opset version 7 or above for opset domain 'ai.onnx'. Please upgrade your model to opset 7 or higher. For now, this opset 6 model may run depending upon legacy support of some older opset version operators.
2024-05-09 14:39:25.658940439 [W:onnxruntime:, transpose_optimizer.cc:28 ApplyImpl] Transpose optimizer failed: Unsupported ONNX opset: 6
Traceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 340, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 267, in main
sess = ort.InferenceSession(model_name,
File "/usr/local/lib/python3.8/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 419, in init
self._create_inference_session(providers, provider_options, disabled_optimizers)
File "/usr/local/lib/python3.8/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 463, in _create_inference_session
sess.initialize_session(providers, provider_options, disabled_optimizers)
onnxruntime.capi.onnxruntime_pybind11_state.NotImplemented: [ONNXRuntimeError] : 9 : NOT_IMPLEMENTED : Could not find an implementation for BatchNormalization(6) node with name ''

     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
:x:unet: ERROR - check error outputTraceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 340, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 207, in main
model = migraphx.parse_onnx(model_name,
RuntimeError: /src/AMDMIGraphX/src/onnx/onnx_parser.cpp:264: parse_from: PARSE_FROM: Failed reading onnx file: /new-saved-models/unet/model.onnx

     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
:red_circle:bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

:x:bert_large: ERROR - check error outputTraceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 340, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 205, in main
model = migraphx.parse_onnx(model_name, default_dim_value=batch)
RuntimeError: /src/AMDMIGraphX/src/onnx/onnx_parser.cpp:264: parse_from: PARSE_FROM: Failed reading onnx file: /new-saved-models/bert/model.onnx

     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance

migraphx-bot avatar May 03 '24 17:05 migraphx-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.78%. Comparing base (bc6c794) to head (f327b0a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3035   +/-   ##
========================================
  Coverage    91.78%   91.78%           
========================================
  Files          485      485           
  Lines        18863    18865    +2     
========================================
+ Hits         17314    17316    +2     
  Misses        1549     1549           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 15:05 codecov[bot]