AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

`Split` dynamic shape parsing update

Open CharlieL7 opened this issue 9 months ago • 3 comments

  • Updates parsing of Split ONNX operator to support dynamic shapes for the case of no split attribute or input.
    • Should be possible to extend dynamic shape support to other cases in the future

CharlieL7 avatar May 03 '24 14:05 CharlieL7

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.94%. Comparing base (b9cce08) to head (fb7fa55). Report is 148 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3034      +/-   ##
===========================================
+ Coverage    91.92%   91.94%   +0.01%     
===========================================
  Files          489      489              
  Lines        19275    19309      +34     
===========================================
+ Hits         17719    17753      +34     
  Misses        1556     1556              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 15:05 codecov[bot]

Test Batch Rate new
fb7fa5
Rate old
716da6
Diff Compare
torchvision-resnet50 64 1,713.20 1,714.31 -0.06% :white_check_mark:
torchvision-resnet50_fp16 64 3,810.68 3,811.27 -0.02% :white_check_mark:
torchvision-densenet121 32 1,452.47 1,453.18 -0.05% :white_check_mark:
torchvision-densenet121_fp16 32 2,436.48 2,438.60 -0.09% :white_check_mark:
torchvision-inceptionv3 32 882.73 883.47 -0.08% :white_check_mark:
torchvision-inceptionv3_fp16 32 1,411.66 1,415.00 -0.24% :white_check_mark:
cadene-inceptionv4 16 407.28 407.87 -0.15% :white_check_mark:
cadene-resnext64x4 16 413.83 413.67 0.04% :white_check_mark:
slim-mobilenet 64 3,824.11 3,822.63 0.04% :white_check_mark:
slim-nasnetalarge 64 97.02 97.02 -0.00% :white_check_mark:
slim-resnet50v2 64 1,651.41 1,651.78 -0.02% :white_check_mark:
bert-mrpc-onnx 8 590.97 592.01 -0.18% :white_check_mark:
bert-mrpc-tf 1 290.58 281.28 3.31% :high_brightness:
pytorch-examples-wlang-gru 1 332.41 339.16 -1.99% :white_check_mark:
pytorch-examples-wlang-lstm 1 298.19 298.76 -0.19% :white_check_mark:
torchvision-resnet50_1 1 454.52 456.46 -0.42% :white_check_mark:
cadene-dpn92_1 1 245.05 244.33 0.30% :white_check_mark:
cadene-resnext101_1 1 189.07 189.19 -0.07% :white_check_mark:
onnx-taau-downsample 1 204.18 204.02 0.08% :white_check_mark:
dlrm-criteoterabyte 1 22.29 22.29 0.03% :white_check_mark:
dlrm-criteoterabyte_fp16 1 41.62 41.58 0.10% :white_check_mark:
agentmodel 1 6,093.73 6,131.58 -0.62% :white_check_mark:
unet_fp16 2 33.74 34.27 -1.57% :white_check_mark:
resnet50v1_fp16 1 551.13 559.90 -1.57% :white_check_mark:
resnet50v1_int8 1 463.46 462.93 0.11% :white_check_mark:
bert_base_cased_fp16 64 620.61 623.40 -0.45% :white_check_mark:
bert_large_uncased_fp16 32 193.77 194.19 -0.22% :white_check_mark:
bert_large_fp16 1 103.93 104.03 -0.10% :white_check_mark:
distilgpt2_fp16 16 1,187.58 1,191.27 -0.31% :white_check_mark:
yolov5s 1 298.31 298.33 -0.01% :white_check_mark:
tinyllama 1 23.32 23.33 -0.03% :white_check_mark:
vicuna-fastchat 1 133.67 132.94 0.55% :white_check_mark:
whisper-tiny-encoder 1 241.13 240.77 0.15% :white_check_mark:
whisper-tiny-decoder 1 245.45 245.54 -0.04% :white_check_mark:

Check results before merge :high_brightness:

migraphx-bot avatar May 03 '24 15:05 migraphx-bot


     :white_check_mark: bert-mrpc-onnx: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-resnext101_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
     :white_check_mark: unet: PASSED: MIGraphX meets tolerance
     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert_base_cased_fp16: PASSED: MIGraphX meets tolerance
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     :white_check_mark: bert_large: PASSED: MIGraphX meets tolerance
     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance

migraphx-bot avatar May 03 '24 15:05 migraphx-bot

Dont forget to fix the format issue

causten avatar May 30 '24 13:05 causten