AMDMIGraphX
AMDMIGraphX copied to clipboard
ROCmSoftwarePlatform
Moving CI to 6.1
I think there might be another package thats needed to install clang-format.
| Test | Batch | Rate new 98f780 |
Rate old 771f29 |
Diff | Compare |
|---|---|---|---|---|---|
| torchvision-resnet50 | 64 | 1,751.89 | 1,743.17 | 0.50% | :white_check_mark: |
| torchvision-resnet50_fp16 | 64 | 4,085.25 | 4,067.49 | 0.44% | :white_check_mark: |
| torchvision-densenet121 | 32 | 1,467.47 | 1,463.04 | 0.30% | :white_check_mark: |
| torchvision-densenet121_fp16 | 32 | 2,529.20 | 2,520.02 | 0.36% | :white_check_mark: |
| torchvision-inceptionv3 | 32 | 890.04 | 885.80 | 0.48% | :white_check_mark: |
| torchvision-inceptionv3_fp16 | 32 | 1,485.62 | 1,476.08 | 0.65% | :white_check_mark: |
| cadene-inceptionv4 | 16 | 412.61 | 410.49 | 0.52% | :white_check_mark: |
| cadene-resnext64x4 | 16 | 419.84 | 417.74 | 0.50% | :white_check_mark: |
| slim-mobilenet | 64 | 4,008.97 | 3,991.52 | 0.44% | :white_check_mark: |
| slim-nasnetalarge | 64 | 101.02 | 100.61 | 0.41% | :white_check_mark: |
| slim-resnet50v2 | 64 | 1,680.99 | 1,673.57 | 0.44% | :white_check_mark: |
| bert-mrpc-onnx | 8 | 616.91 | 614.20 | 0.44% | :white_check_mark: |
| bert-mrpc-tf | 1 | 279.13 | 278.28 | 0.31% | :white_check_mark: |
| pytorch-examples-wlang-gru | 1 | 319.55 | 332.86 | -4.00% | :red_circle: |
| pytorch-examples-wlang-lstm | 1 | 293.29 | 291.71 | 0.54% | :white_check_mark: |
| torchvision-resnet50_1 | 1 | 468.61 | 470.33 | -0.36% | :white_check_mark: |
| cadene-dpn92_1 | 1 | 246.98 | 247.05 | -0.03% | :white_check_mark: |
| cadene-resnext101_1 | 1 | 199.46 | 203.41 | -1.94% | :white_check_mark: |
| onnx-taau-downsample | 1 | 206.41 | 205.56 | 0.41% | :white_check_mark: |
| dlrm-criteoterabyte | 1 | 22.92 | 22.83 | 0.39% | :white_check_mark: |
| dlrm-criteoterabyte_fp16 | 1 | 42.71 | 42.57 | 0.34% | :white_check_mark: |
| agentmodel | 1 | 6,309.90 | 6,407.05 | -1.52% | :white_check_mark: |
| unet_fp16 | 2 | 34.14 | 34.08 | 0.17% | :white_check_mark: |
| resnet50v1_fp16 | 1 | 594.74 | 596.97 | -0.37% | :white_check_mark: |
| resnet50v1_int8 | 1 | 580.14 | 577.76 | 0.41% | :white_check_mark: |
| bert_base_cased_fp16 | 64 | 646.44 | 642.82 | 0.56% | :white_check_mark: |
| bert_large_uncased_fp16 | 32 | 199.06 | 197.88 | 0.60% | :white_check_mark: |
| bert_large_fp16 | 1 | 117.54 | 117.05 | 0.42% | :white_check_mark: |
| distilgpt2_fp16 | 16 | 1,213.52 | 1,204.65 | 0.74% | :white_check_mark: |
| yolov5s | 1 | 301.92 | 300.51 | 0.47% | :white_check_mark: |
| tinyllama | 1 | 23.34 | 23.23 | 0.48% | :white_check_mark: |
| vicuna-fastchat | 1 | 133.33 | 132.26 | 0.81% | :white_check_mark: |
| whisper-tiny-encoder | 1 | 244.06 | 243.52 | 0.22% | :white_check_mark: |
| whisper-tiny-decoder | 1 | 256.66 | 255.68 | 0.38% | :white_check_mark: |
This build is not recommended to merge :red_circle:
:red_circle:bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output
We should disable the cppcoreguidelines-missing-std-forward, modernize-type-traits and misc-include-cleaner tidy checks and then open an issue where we can address this in a seperate PRs(or perhaps we decide we want to disable them).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.77%. Comparing base (
9186c37) to head (ed86fb7).
Additional details and impacted files
@@ Coverage Diff @@
## develop #2977 +/- ##
============================================
+ Coverage 0 91.77% +91.77%
============================================
Files 0 484 +484
Lines 0 18711 +18711
============================================
+ Hits 0 17172 +17172
- Misses 0 1539 +1539
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think you will need to suppress cppcoreguidelines-use-default-member-init, and bugprone-switch-missing-default-case,-warnings-as-errors. For the cppcoreguidelines-noexcept-swap warning you can just add noexcept to the swap function.
This still needed or do we want to close this and aim to merge in 6.2 once it's ready?
This still needed or do we want to close this and aim to merge in 6.2 once it's ready?
We should try to get this merged in. We just need to disable a few more tidy checks:
- cppcoreguidelines-use-default-member-init
- bugprone-switch-missing-default-case
@causten Can you add these exceptions, so we can get this merged?
This still needed or do we want to close this and aim to merge in 6.2 once it's ready?
We should try to get this merged in. We just need to disable a few more tidy checks:
- cppcoreguidelines-use-default-member-init
- bugprone-switch-missing-default-case
@causten Can you add these exceptions, so we can get this merged?
Can we target 6.1.3 then instead of 6.1?
Can we target 6.1.3 then instead of 6.1?
I opened #3335 to upgrade to this version and fix the tidy issues.