AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Eliminate concat changes to insert copies for nonpacked axes

Open kahmed10 opened this issue 1 year ago • 3 comments

Currently, we only eliminate concat if the axis = 0 or the axis > 0 but the data is packed (i.e., all dims up to axis = 1). This PR changes it so that copies are inserted.

kahmed10 avatar Apr 12 '24 15:04 kahmed10

Test Batch Rate new
d995fe
Rate old
070c2e
Diff Compare
torchvision-resnet50 64 2,824.56 2,826.14 -0.06% :white_check_mark:
torchvision-resnet50_fp16 64 6,558.41 6,576.83 -0.28% :white_check_mark:
torchvision-densenet121 32 2,094.51 2,090.60 0.19% :white_check_mark:
torchvision-densenet121_fp16 32 3,696.12 3,686.13 0.27% :white_check_mark:
torchvision-inceptionv3 32 1,604.19 1,605.47 -0.08% :white_check_mark:
torchvision-inceptionv3_fp16 32 2,555.28 2,555.50 -0.01% :white_check_mark:
cadene-inceptionv4 16 716.78 717.75 -0.14% :white_check_mark:
cadene-resnext64x4 16 680.82 680.72 0.01% :white_check_mark:
slim-mobilenet 64 5,865.53 5,908.97 -0.74% :white_check_mark:
slim-nasnetalarge 64 153.59 153.88 -0.19% :white_check_mark:
slim-resnet50v2 64 2,589.69 2,586.75 0.11% :white_check_mark:
bert-mrpc-onnx 8 919.95 960.21 -4.19% :red_circle:
bert-mrpc-tf 1 438.58 401.32 9.28% :high_brightness:
pytorch-examples-wlang-gru 1 419.92 415.54 1.05% :white_check_mark:
pytorch-examples-wlang-lstm 1 381.86 384.72 -0.74% :white_check_mark:
torchvision-resnet50_1 1 603.45 604.26 -0.13% :white_check_mark:
cadene-dpn92_1 1 392.45 394.64 -0.55% :white_check_mark:
cadene-resnext101_1 1 333.10 326.95 1.88% :white_check_mark:
onnx-taau-downsample 1 306.39 307.13 -0.24% :white_check_mark:
dlrm-criteoterabyte 1 28.80 28.79 0.02% :white_check_mark:
dlrm-criteoterabyte_fp16 1 48.46 48.21 0.53% :white_check_mark:
agentmodel 1 7,423.52 7,621.72 -2.60% :white_check_mark:
unet_fp16 2 57.70 57.79 -0.17% :white_check_mark:
resnet50v1_fp16 1 884.00 895.00 -1.23% :white_check_mark:
resnet50v1_int8 1 828.81 826.04 0.34% :white_check_mark:
bert_base_cased_fp16 64 1,053.37 1,053.69 -0.03% :white_check_mark:
bert_large_uncased_fp16 32 300.75 301.61 -0.28% :white_check_mark:
bert_large_fp16 1 159.07 158.93 0.09% :white_check_mark:
distilgpt2_fp16 16 1,858.36 1,857.93 0.02% :white_check_mark:
yolov5s 1 466.78 474.32 -1.59% :white_check_mark:
tinyllama 1 33.01 32.96 0.16% :white_check_mark:
vicuna-fastchat 1 158.58 157.50 0.68% :white_check_mark:
whisper-tiny-encoder 1 348.21 347.91 0.09% :white_check_mark:
whisper-tiny-decoder 1 401.73 396.59 1.30% :white_check_mark:

This build is not recommended to merge :red_circle:

migraphx-bot avatar Apr 12 '24 17:04 migraphx-bot


     :white_check_mark: bert-mrpc-onnx: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-resnext101_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
     :white_check_mark: unet: PASSED: MIGraphX meets tolerance
     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert_base_cased_fp16: PASSED: MIGraphX meets tolerance
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     :white_check_mark: bert_large: PASSED: MIGraphX meets tolerance
     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance

migraphx-bot avatar Apr 12 '24 17:04 migraphx-bot

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.85%. Comparing base (c3c0980) to head (ba8e9a4). Report is 1 commits behind head on develop.

Files Patch % Lines
src/eliminate_concat.cpp 94.11% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2969   +/-   ##
========================================
  Coverage    91.85%   91.85%           
========================================
  Files          483      483           
  Lines        18580    18602   +22     
========================================
+ Hits         17066    17087   +21     
- Misses        1514     1515    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 01:04 codecov[bot]