AMDMIGraphX
AMDMIGraphX copied to clipboard
Inconsistent and incorrect use of operator descriptor in onnx parsing
There are onnx parse() functions which use opd.op_name inside MIGRAPHX_THROW macro, although this operator descriptor field is not initialized.
List of such files:
- src/onnx/parse_instancenorm.cpp
- src/onnx/parse_randomnormal_ops.cpp
- src/onnx/parse_randomuniform_ops.cpp
- src/onnx/parse_resize.cpp
In src/onnx/parse_qlinearpooling.cpp parse() function opd.onnx_name is used inside MIGRAPHX_THROW macros, which is not consistent with other prints (However, could be a better solution as onnx_name is more precise and op_name sometimes does not point out precisely which onnx operator causes an error).
There are onnx parse() functions which use opd.op_name inside tune_axis function, although this operator descriptor field is not initialized.
List of such files:
- src/onnx/parse_dequantizelinear.cpp
- src/onnx/parse_gather_elements.cpp
- src/onnx/parse_onehot.cpp
- src/onnx/parse_quantizelinear.cpp
- src/onnx/parse_split.cpp
- src/onnx/parse_unique.cpp