AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Published 20 hours ago • verified publisher icon ROCmSoftwarePlatform

Write a onnx parser/verify tests for FP8

Open ahsan-ca opened this issue 11 months ago • 3 comments

Write a onnx parser test for FP8

ahsan-ca avatar Mar 13 '24 18:03 ahsan-ca

Working on higher priority DLM issues and JIRA tickets so could not work on this one.

ahsan-ca avatar Mar 27 '24 19:03 ahsan-ca

Working on higher priority DLM issues and JIRA tickets so could not work on this one.

Same as before, did not get a chance to work on this. Now that the other issues have been fixed, will pick this up again.

ahsan-ca avatar Apr 10 '24 18:04 ahsan-ca

I was able to work on this a bit during the last sprint and was able to get past the error I was seeing for verification. I will continue to work on this to add more tests.

ahsan-ca avatar Apr 24 '24 17:04 ahsan-ca

Was able to work on this last week:

  • Added tests covering the following operators: reduce_max, reduce_sum, avgpool, maxpool, sine, cosine, sqrt, division, multiplication.

  • Addressed comments to modify existing test cases.

  • Investigated failures after modifying tests.

  • Opened a separate PR to modify parse_shrink.cpp and related tests to remove redundant convert operations.

ahsan-ca avatar Jun 05 '24 16:06 ahsan-ca

PR to update parse gemm and update gemm tests so I could address the comments on gemm_fp8 test: https://github.com/ROCm/AMDMIGraphX/pull/3158

ahsan-ca avatar Jun 06 '24 10:06 ahsan-ca