AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Update `pass_manager` to handle updating the cached shape when submodule shapes change

Open CharlieL7 opened this issue 1 year ago • 0 comments

  • Extend code in pass_manager.cpp:run_passes(prog, root_mod, passes, trace) to handle updating the cached shape from op.compute_shape(shape_inputs, mod_inputs) when mod_inputs shape changes.
    • Currently, the cached shape is not updated when submodule inputs have their output shape changed.
    • Can probably be implemented by keeping track of the parent instructions that need to be updated after all submodules are updated.
  • Remove the simplify_select_module_output_shape matcher and pass from simplify_dyn_ops.cpp. Move the shape computation logic into select_module.compute_shape().

CharlieL7 avatar Feb 09 '24 17:02 CharlieL7