AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

Better handle arguments that requires `--fill1` or `--fill0` for a model inside `migraphx-driver`.

Open umangyadav opened this issue 2 years ago • 1 comments

many models have input parameters that are int types and usually such parameters are used as indices of some sort or are passed to operators that expect values in certain range.

Example of such models are "DLRM" and "BERT". if those models are run without --fill1 or --fill0 for some of the parameters, it would seg-fault.

mgiraphx-driver can handle it better than just having it seg-fault.

For the static-shaped model, it can know in advance where those int parameters are used and how it is used. That way it can possibly deduce the valid range of values those parameters can take.

migraphx-driver should then only generate values in those range for the model run without having users to pass --fill1 or --fill0.

umangyadav avatar Jul 26 '23 14:07 umangyadav

Seg faults, page faults and the like are very dramatic events, which strongly diminish user confidence not only on migraphx, but on rocm at large.

At a minimum, can we decorate the failure with some actionable suggestions, for example suggesting that the user set fill0,1?

none of the above behavior is obvious to anybody...

hgaspar avatar Jul 26 '23 14:07 hgaspar