rpp icon indicating copy to clipboard operation
rpp copied to clipboard

WIP - Test suite - hip build fix

Open r-abishek opened this issue 1 year ago • 2 comments

  • Add fix for test suite hip build

r-abishek avatar Sep 19 '24 17:09 r-abishek

@r-abishek can you add the fix for Issue #454 here?

kiritigowda avatar Sep 21 '24 17:09 kiritigowda

@kiritigowda Added iomanip PR updates here - https://github.com/r-abishek/rpp/pull/344

r-abishek avatar Sep 23 '24 21:09 r-abishek

@r-abishek any updates on this PR? Need the fix to solve test failures

kiritigowda avatar Oct 01 '24 20:10 kiritigowda

@rrawther - this fix is required to pass CI -- issue mentioned -- #454

kiritigowda avatar Oct 02 '24 18:10 kiritigowda

@r-abishek : We need to merge this PR asap as CI is failing on bunch of PRs. Is it still WIP?

rrawther avatar Oct 02 '24 18:10 rrawther

@kiritigowda @rrawther Please see screenshots below with lsb_release -a command to show Ubuntu passing on 22.04 and 20.04:

Passing on Ubuntu 22.04: image

Passing on Ubuntu 20.04: image

r-abishek avatar Oct 02 '24 18:10 r-abishek

@kiritigowda @rrawther Current fails on CI are just since the right libs are not installed on the CI machine for both SLES and RHEL:

On RHEL9: image

On SLES15: image

r-abishek avatar Oct 02 '24 18:10 r-abishek

@r-abishek - we are installing all the deps for CI. The failure on RHEL 8 can be verified with this fix.

kiritigowda avatar Oct 02 '24 20:10 kiritigowda

@r-abishek - errors from this PR - http://math-ci.amd.com/job/mainline/job/precheckin/job/rpp/job/PR-453/5/pipeline-console/log?nodeId=282

: In file included from /opt/rocm-6.3.0-14898/share/rpp/test/HOST/Tensor_misc_host.cpp:25:
1: /opt/rocm-6.3.0-14898/share/rpp/test/HOST/../rpp_test_suite_misc.h:97:39: error: implicit instantiation of undefined template 'std::array<unsigned int, 4>'
1:                 std::array<Rpp32u, 4> roi = {0, 0, 100, 100};
1:                                       ^
1: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/tuple:1595:45: note: template is declared here
1:   template<typename _Tp, size_t _Nm> struct array;
1:                                             ^
1: In file included from /opt/rocm-6.3.0-14898/share/rpp/test/HOST/Tensor_misc_host.cpp:25:
1: /opt/rocm-6.3.0-14898/share/rpp/test/HOST/../rpp_test_suite_misc.h:104:39: error: implicit instantiation of undefined template 'std::array<unsigned int, 6>'
1:                 std::array<Rpp32u, 6> roi = {0, 0, 0, 50, 50, 8};
1:                                       ^
1: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/tuple:1595:45: note: template is declared here
1:   template<typename _Tp, size_t _Nm> struct array;
1:                                             ^
1: In file included from /opt/rocm-6.3.0-14898/share/rpp/test/HOST/Tensor_misc_host.cpp:25:
1: /opt/rocm-6.3.0-14898/share/rpp/test/HOST/../rpp_test_suite_misc.h:118:39: error: implicit instantiation of undefined template 'std::array<unsigned int, 4>'
1:                 std::array<Rpp32u, 4> roi = {0, 0, 1920, 1080};
1:                                       ^
1: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/tuple:1595:45: note: template is declared here
1:   template<typename _Tp, size_t _Nm> struct array;
1:                                             ^
1: In file included from /opt/rocm-6.3.0-14898/share/rpp/test/HOST/Tensor_misc_host.cpp:25:
1: /opt/rocm-6.3.0-14898/share/rpp/test/HOST/../rpp_test_suite_misc.h:125:39: error: implicit instantiation of undefined template 'std::array<unsigned int, 6>'
1:                 std::array<Rpp32u, 6> roi = {0, 0, 0, 1920, 1080, 3};
1:                                       ^
1: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/tuple:1595:45: note: template is declared here
1:   template<typename _Tp, size_t _Nm> struct array;
1:                                             ^
1: In file included from /opt/rocm-6.3.0-14898/share/rpp/test/HOST/Tensor_misc_host.cpp:25:
1: /opt/rocm-6.3.0-14898/share/rpp/test/HOST/../rpp_test_suite_misc.h:132:39: error: implicit instantiation of undefined template 'std::array<unsigned int, 8>'
1:                 std::array<Rpp32u, 8> roi = {0, 0, 0, 0, 1, 128, 128, 128};
1:                                       ^
1: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/tuple:1595:45: note: template is declared here
1:   template<typename _Tp, size_t _Nm> struct array;
1:                                             ^
1: 5 errors generated.
1: make[3]: *** [CMakeFiles/Tensor_misc_host.dir/build.make:76: CMakeFiles/Tensor_misc_host.dir/Tensor_misc_host.cpp.o] Error 1
1: make[3]: Leaving directory '/var/jenkins_home/workspace/mainline_precheckin_rpp_PR-453/govcksC4S/rpp/build/release/utilities/test_suite/build'
1: make[2]: *** [CMakeFiles/Makefile2:119: CMakeFiles/Tensor_misc_host.dir/all] Error 2
1: make[2]: *** Waiting for unfinished jobs....

Check full report - http://math-ci.amd.com/job/mainline/job/precheckin/job/rpp/job/PR-453/5/pipeline-console/?selected-node=279

kiritigowda avatar Oct 11 '24 23:10 kiritigowda

@kiritigowda All Jenkins CI passing now for this PR - Ubuntu/SLES/RHEL. Strict checks introduced in CMake for all packages necessary to build and run each of the 4 test sets. PR description changed to point to all issues it addresses.

r-abishek avatar Oct 12 '24 20:10 r-abishek

@kiritigowda @rrawther Last minor readme commit is really taking too long to run the CI.

Please see CI passing on the second last commit (Commit ID - https://github.com/ROCm/rpp/pull/453/commits/3945af181cc251eb4257d291c4d4d331d4ae11a6). image

r-abishek avatar Oct 16 '24 16:10 r-abishek

Merge pending - http://math-ci.amd.com/job/mainline/job/precheckin/job/rpp/job/PR-453/16/pipeline-graph/

kiritigowda avatar Oct 16 '24 17:10 kiritigowda

Merge pending - http://math-ci.amd.com/job/mainline/job/precheckin/job/rpp/job/PR-453/16/pipeline-graph/

@kiritigowda The Ubuntu22+gfx90a may not finish since all nodes show offline: image

r-abishek avatar Oct 16 '24 21:10 r-abishek

@kiritigowda All 13 CI checks passing now

r-abishek avatar Oct 16 '24 21:10 r-abishek