edited to conform to standards

Open spolifroni-amd opened this issue 1 year ago • 2 comments

Oct 08 '24 15:10 spolifroni-amd

Hi @stanleytsang-amd, shouldn't your version string be at least "3.2.1" in the release branch at this point? -- And now "3.2.2" for the upcoming ROCm 6.2.4 release? https://github.com/ROCm/rocPRIM/blob/05bdf4df196a037e03a5f7da2f856c2c2467bd01/CMakeLists.txt#L129

Your changelog in the release branch says

rocPRIM-3.2.1 for ROCm 6.2.1

Kinda confusing

Oct 08 '24 16:10 peterjunpark

Hi @stanleytsang-amd, shouldn't your version string be at least "3.2.1" in the release branch at this point? -- And now "3.2.2" for the upcoming ROCm 6.2.4 release?

https://github.com/ROCm/rocPRIM/blob/05bdf4df196a037e03a5f7da2f856c2c2467bd01/CMakeLists.txt#L129

Your changelog in the release branch says
rocPRIM-3.2.1 for ROCm 6.2.1
Kinda confusing

Hi, yes you are correct. It has been updated now in the 6.2 release branch.

Oct 11 '24 16:10 stanleytsang-amd