rocFFT icon indicating copy to clipboard operation
rocFFT copied to clipboard

Require rocFFT use hip-config.cmake to find HIP

Open littlewu2508 opened this issue 1 year ago • 1 comments

Sometimes rocFFT use FindHIP.cmake which is not desired -- it does not have hip::device and hip::host target imported and result in cmake generating error.

Reference: https://bugs.gentoo.org/932155

littlewu2508 avatar Oct 20 '24 15:10 littlewu2508

[FindHIP.cmake] does not have hip::device and hip::host target imported and result in cmake generating error.

There were some discussions ages ago about making FindHIP.cmake do a find_package(hip CONFIG) itself to fix this, but I guess the discussion never ended up leading to action. We should probably enhance FindHIP to eliminate this problem for all libraries and programs that use HIP.

cgmb avatar Oct 22 '24 18:10 cgmb