rocBLAS icon indicating copy to clipboard operation
rocBLAS copied to clipboard

[Bug]: use roctracer/roctx.h without cmake find_package

Open trixirt opened this issue 8 months ago • 2 comments

Describe the bug

A clear and concise description of what the bug or problem is.

On 6.4.0, roctx.h is included here https://github.com/ROCm/rocBLAS/blob/rocm-6.4.0/library/src/include/logging.hpp#L44 without having a cmake find_package(roctracer, REQUIRED)

Will cause a compile error that should have been caught at config time Most/all linux distro's will hit this problem as they must build shared objects, not static libs. I am using Fedora, rawhide.

To Reproduce

Precise version of rocBLAS installed or rocBLAS commit hash if building from source. Steps to reproduce the behavior:

  1. Install '...' version '...'
  2. Run '...' with data '...'
  3. See error on logfile '...'

Expected behavior

A clear and concise description of what you expected to happen.

Log-files

Add full logfiles to help explain your problem.

Environment

Hardware description
CPU device name
GPU device name

The above hardware Table information can be generated by command:

rocminfo | grep Marketing
Software version
rocm-core v0.0
rocblas v0.0

The above software Table information can be queried with:

Ubuntu/Debian:
dpkg -s rocm-core | grep Version
dpkg -s rocblas | grep Version
Centos/RHEL:
rpm -qa | grep rocm-core
rpm -qa | grep rocblas
SLES:
zypper se -s | grep rocm-core
zypper se -s | grep rocblas

Make sure that ROCm is correctly installed and to capture detailed environment information run the following command:

printf '=== environment\n' > environment.txt &&
printf '\n\n=== date\n' >> environment.txt && date >> environment.txt &&
printf '\n\n=== Linux Kernel\n' >> environment.txt && uname -a  >> environment.txt &&
printf '\n\n=== rocm-smi' >> environment.txt && rocm-smi  >> environment.txt &&
printf '\n\n' >> environment.txt && hipconfig  >> environment.txt &&
printf '\n\n=== rocminfo\n' >> environment.txt && rocminfo  >> environment.txt &&
printf '\n\n=== lspci VGA\n' >> environment.txt && lspci | grep -i vga >> environment.txt

Attach environment.txt

Additional context

Add any other context about the problem here.

trixirt avatar Apr 14 '25 20:04 trixirt

Confirming this, ran into this as well on nixos

Same for rccl, btw

justinkb avatar Apr 15 '25 10:04 justinkb

Thanks for reporting this issue , this PR : https://github.com/ROCm/rocBLAS/pull/1590 should fix the compilation issue caused due to missing rocTX header. Merged to develop commit : https://github.com/ROCm/rocBLAS/commit/5d4c577b59cf1039d231e1b894ad81114f2be1f0

rkamd avatar May 21 '25 13:05 rkamd