rocALUTION icon indicating copy to clipboard operation
rocALUTION copied to clipboard

[Issue]: `rocalution-config.cmake` file attempts to find HIP even if rocALUTION was built w/o HIP support

Open juhanikataja opened this issue 1 year ago • 1 comments

Problem Description

rocALUTION compiles without HIP support but resulting lib/cmake/rocalution/rocalution-config.cmake anyhow tries to find HIP (line 90: find_dependency(HIP)).

Commenting that line out will enables use of rocALUTION even without HIP being available.

No ROCm/HIP was needed to build rocALUTION.

Operating System

22.04.5 LTS (Jammy Jellyfish)

CPU

AMD Ryzen 5 7530U with Radeon Graphics

GPU

AMD Instinct MI250X

ROCm Version

ROCm 6.2.0

ROCm Component

HIP

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

juhanikataja avatar Sep 24 '24 10:09 juhanikataja

See #248 for a potential fix.

mmuetzel avatar Sep 24 '24 16:09 mmuetzel

Are you in contact with the people that package rocALUTION for Debian? If you are: Could you please ask if they could cherry-pick the commit that fixes this issue (https://github.com/ROCm/rocALUTION/commit/a7cdd397f1a293fe8fab2082e6e6aa13ac4af640)? As it stands, the rocalution package that is distributed by Ubuntu (inherited from Debian afaict) cannot be used in CMake projects without work-arounds.

mmuetzel avatar Sep 30 '24 10:09 mmuetzel

Hi @juhanikataja,

This issue should be resolved with #248, please give it a try and let me know if the issue persists, thanks!

darren-amd avatar Oct 29 '24 14:10 darren-amd

Thanks @darren-amd and @mmuetzel!

The issue did resolve in commit a7cdd397f1a293fe8fab2082e6e6aa13ac4af640

I don't know the rocALUTION Debian packagers unfortunately.

juhanikataja avatar Oct 29 '24 14:10 juhanikataja

Awesome! Closing as complete.

darren-amd avatar Oct 29 '24 14:10 darren-amd