omniperf icon indicating copy to clipboard operation
omniperf copied to clipboard

Use proper name and icon in browser tab for Omniperf

Open xuchen-amd opened this issue 1 year ago • 4 comments

Use proper/rebranded name and icon in browser tab for Omniperf/rocprof-compute Web UI.

xuchen-amd avatar Sep 13 '24 16:09 xuchen-amd

Please format Python code using black, e.g.,

python3 -m pip install black
cd omniperf
black .

coleramos425 avatar Sep 13 '24 17:09 coleramos425

@dgaliffiAMD would you recommend we wait to merge until the naming rebrand PR to "rocprof-compute" is finalized?

coleramos425 avatar Sep 13 '24 17:09 coleramos425

@dgaliffiAMD would you recommend we wait to merge until the naming rebrand PR to "rocprof-compute" is finalized?

Yes, I think that would be best. So, we don't confuse people with a halfway rebranded tool. :)

dgaliffiAMD avatar Sep 13 '24 17:09 dgaliffiAMD

@xuchen-amd looks good. Same feedback as before about adding that sign-off to your commits:

image

coleramos425 avatar Sep 19 '24 19:09 coleramos425