omniperf icon indicating copy to clipboard operation
omniperf copied to clipboard

Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub

Open ELCapitanLLNL opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Please describe. no

Describe the solution you'd like I would like do be able to pull an image of grafana with the omniperf plug-in so can I can docker pull omniperf-grafana as an example.

Describe alternatives you've considered Currently I am using the Dockerfile provided in the repo in https://github.com/ROCm/omniperf/blob/amd-staging/grafana/Dockerfile However, I need to modify it to add my secret sauce, which makes it more difficult to maintain.

Additional context Currently other omniperf images are being hosted under Mr. Ramos account at https://hub.docker.com/u/colramos

ELCapitanLLNL avatar Aug 24 '24 00:08 ELCapitanLLNL

This should be a straightforward task. I'll need to confirm with the project PM to sign off on publishing this container. Expect an update shortly...

coleramos425 avatar Aug 29 '24 15:08 coleramos425

hi @coleramos425 , any update on this straightforward task? thank you!

ELCapitanLLNL avatar Oct 01 '24 02:10 ELCapitanLLNL

CC: @njobypet

For approval on container publishing

coleramos425 avatar Oct 01 '24 14:10 coleramos425

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

njobypet avatar Oct 01 '24 17:10 njobypet

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

Yes we can, we'll just need to wait for #428 to merge. @njobypet I am creating a subtask in Xuan's PR to make sure this is included.

coleramos425 avatar Oct 02 '24 20:10 coleramos425

@coleramos425 , Please check grafana licensing requirements as well. Just to ensure that we are good to re-distribute.

njobypet avatar Oct 03 '24 17:10 njobypet

Unfortunately, that's outside of my domain @njobypet. You'll need to reach out to the legal team. Licencing info can be found here. I'll note that in Xuan's ticket.

coleramos425 avatar Oct 03 '24 17:10 coleramos425

Happy Monday!
Any update on this now that the rename happened. Thanks!

ELCapitanLLNL avatar Nov 25 '24 16:11 ELCapitanLLNL

Happy Monday! Any update on this now that the rename happened. Thanks!

CC: @njobypet

coleramos425 avatar Nov 25 '24 17:11 coleramos425

This issue has been migrated to: https://github.com/ROCm/rocm-systems/issues/51

systems-assistant[bot] avatar Aug 06 '25 18:08 systems-assistant[bot]

Imported to ROCm/rocm-systems

amd-hsivasun avatar Aug 06 '25 18:08 amd-hsivasun