k8s-device-plugin icon indicating copy to clipboard operation
k8s-device-plugin copied to clipboard
verified publisher icon ROCm

Minor fixes

Open ArangoGutierrez opened this issue 4 years ago • 9 comments

This patch is a collection of cosmetic fixes, nothing mission critical

  • https://github.com/RadeonOpenCompute/k8s-device-plugin/commit/9a59e22569dfae528f09e8abb9f9fe13a80625ca updates GO and it's dependencies to 1.16
  • https://github.com/RadeonOpenCompute/k8s-device-plugin/commit/9fc3c6e168eb9027a42a197083755a0ddeceb431 Fix Dockerfile formatting and Entrypoint
  • https://github.com/RadeonOpenCompute/k8s-device-plugin/commit/fc9251939298ebebe751f1ce827ffc463494a916 Fix markdown lints on README

ArangoGutierrez avatar Apr 29 '21 02:04 ArangoGutierrez

@y2kenny

ArangoGutierrez avatar Apr 30 '21 19:04 ArangoGutierrez

Please separate out the white space and lint fixes and I will merge those first.

Is the golang update compatible with the supported version of Kubernetes? I recall some compatibility issue in the past w.r.t. golang version but I am not 100% on that.

y2kenny avatar Apr 30 '21 19:04 y2kenny

Ready for second review @y2kenny

ArangoGutierrez avatar Aug 04 '21 22:08 ArangoGutierrez

Please separate out the white space and lint fixes and I will merge those first.

Is the golang update compatible with the supported version of Kubernetes? I recall some compatibility issue in the past w.r.t. golang version but I am not 100% on that.

Done see #22

ArangoGutierrez avatar Aug 04 '21 22:08 ArangoGutierrez

PING @y2kenny

ArangoGutierrez avatar Aug 12 '21 00:08 ArangoGutierrez

PING @y2kenny

ArangoGutierrez avatar Oct 01 '21 19:10 ArangoGutierrez

PING @y2kenny @y2kenny-amd

ArangoGutierrez avatar Jan 18 '22 14:01 ArangoGutierrez

PING @y2kenny @y2kenny-amd

ArangoGutierrez avatar Feb 25 '22 22:02 ArangoGutierrez

PING?

ArangoGutierrez avatar Mar 24 '22 19:03 ArangoGutierrez