hipBLASLt icon indicating copy to clipboard operation
hipBLASLt copied to clipboard

[Issue]: Dependency on Tensile headers

Open trixirt opened this issue 2 years ago • 3 comments

Problem Description

I am packaging hipBLASLt for Fedora. When building with -DBUILD_WITH_TENSILE=OFF post 5.7, there are build errors like this

hipBLASLt/library/src/amd_detail/rocblaslt/src/include/tensile_host.hpp:45:10: fatal error: 'Tensile/DataTypes.hpp' file not found 45 | #include <Tensile/DataTypes.hpp> | ^~~~~~~~~~~~~~~~~~~~~~~

Operating System

Fedora Rawhide

CPU

x86_64

GPU

AMD Instinct MI210

Other

No response

ROCm Version

ROCm 5.7.1

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

the issue tracker drop down on rocm version needs to include 6.0

trixirt avatar Jan 07 '24 13:01 trixirt

@trixirt Can you please check if your issue still occurs with the latest ROCm 6.1.2? If not, please close the ticket. Thanks!

ppanchad-amd avatar Jul 09 '24 15:07 ppanchad-amd

@ppanchad-amd , I have the same error the error with 6.1.1/6.1.2, it occurs when user tries to build hipBLASLt with -DBUILD_WITH_TENSILE=OFF (exactly because of this option). The real problem is that this option can not be turned off: not only it fails with fatal error: 'Tensile/DataTypes.hpp' file not found, after adding this header to include path it still fails down the code.

In Gentoo I solved this issue by adding this patch: https://github.com/gentoo/gentoo/blob/master/sci-libs/hipBLASLt/files/hipBLASLt-6.1.1-no-arch.patch. When user has no gfx90a/gfx940/gfx941/gfx942 it allows to build without Tensile as a dummy library just to proceed with pytorch compilation. Otherwise BUILD_WITH_TENSILE must be enabled.

AngryLoki avatar Jul 10 '24 16:07 AngryLoki

As @AngryLoki says, this still an issue, the option can not be turned off and worse, hipblastlt uses it's own copy of tensile, this conflicts with rocblas's copy.

trixirt avatar Jul 13 '24 11:07 trixirt

Hi @trixirt. Internal ticket has been created to investigate your issue. Thanks!

ppanchad-amd avatar Oct 23 '24 19:10 ppanchad-amd

hipblaslt doesn't support "BUILD_WITH_TENSILE=OFF" so far. BUILD_WITH_TENSILE=ON is must

jichangjichang avatar Oct 25 '24 09:10 jichangjichang

That is a regression then, it used to build without tensile.

trixirt avatar Oct 25 '24 20:10 trixirt