[Issue]: Dependency on msgpack even when -DTensile_LIBRARY_FORMAT=yaml

[trixirt]

Problem Description

tensilelite checks if msgpack can be imported here https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/LibraryIO.py#L63

but there is no check here https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/Ops/ExtOpCreateLibrary.py#L27

For distro's without a python msgpack, like RHEL, this is a problem.

Operating System

RHEL 10

CPU

ALL

GPU

AMD Instinct MI210

Other

No response

ROCm Version

ROCm 6.2.3

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

The release drop down for issues needs to be updated. the release is 6.3.3

[trixirt]

The msgpack package is checked for conditionally here https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/Source/lib/CMakeLists.txt#L99

but is used unconditionally here https://github.com/ROCm/hipBLASLt/blob/develop/library/src/amd_detail/hipblaslt-ext-op-internal.hpp#L37

msgpack should be required in the toplevel CMakeLists.txt

[ppanchad-amd]

Hi @trixirt. Internal ticket has been created to investigate this issue. Thanks!

[cj401-amd]

@ppanchad-amd,

on rocm/tensorflow-build:latest-jammy-python3.11-rocm6.3.0, after apt install python3.10-venv, I am trying bash install.sh and still get

CMake Error at build/release/virtualenv/lib/python3.10/site-packages/Tensile/Source/lib/CMakeLists.txt:118 (find_package):
  By not providing "Findmsgpack.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "msgpack", but
  CMake did not find one.

  Could not find a package configuration file provided by "msgpack" with any
  of the following names:

    msgpackConfig.cmake
    msgpack-config.cmake

  Add the installation prefix of "msgpack" to CMAKE_PREFIX_PATH or set
  "msgpack_DIR" to a directory containing one of the above files.  If
  "msgpack" provides a separate development package or SDK, be sure it has
  been installed.


-- Configuring incomplete, errors occurred!

[cj401-amd]

The above is solved by apt install libmsgpack-dev, however, there is another issue.

[adityas-amd]

Hi @cj401-amd could you please clarify on another issue.

[assistant-librarian[bot]]

This issue has been migrated to: https://github.com/ROCm/rocm-libraries/issues/319

[idass1990]

Closing the issue in this repo. Please refer to the migrated issue for updates.