Removed unused code paths that referrs to unimplemented addInst method.

[tcgu-amd]

Related issue: https://github.com/ROCm/hipBLASLt/issues/1223

Removed sections of code that contains addInst & replaced some code paths containing addInst() raise NotImplementedError.

[tcgu-amd]

Could you just comment out (or raise NotImplementedError) the codes where to use addInst()?

Hi, for sure if that's preferred. I was deleting some files because addInst was in an unavoidable code path. E.g. there's only one class in the file and the init function calls addInst unconditionally. I am not sure if raising an error in the init function unconditionally would make sense though, but I can comment out the entire file as opposed to deleting it.

[tcgu-amd]

Hi @jichangjichang I have modified the changes to comment out codes instead. Would you mind taking a look again? Thanks!

[jichangjichang]

@tcgu-amd Could you just replaced only where use addInst() as raise NotImplementedError. example: Before:

cimod.addInst(VMovB32(dst=vgpr(Holder(name="ValuC+1")), src=vgpr("ValuC+%u"%(srcIdx+accImOffset)), comment="Rearrange MI out reg"))`

After:

# cimod.addInst(VMovB32(dst=vgpr(Holder(name="ValuC+1")), src=vgpr("ValuC+%u"%(srcIdx+accImOffset)), comment="Rearrange MI out reg"))" raise NotImplementedError

[tcgu-amd]

@tcgu-amd Could you just replaced only where use addInst() as raise NotImplementedError. example: Before:

cimod.addInst(VMovB32(dst=vgpr(Holder(name="ValuC+1")), src=vgpr("ValuC+%u"%(srcIdx+accImOffset)), comment="Rearrange MI out reg"))`

After:

# cimod.addInst(VMovB32(dst=vgpr(Holder(name="ValuC+1")), src=vgpr("ValuC+%u"%(srcIdx+accImOffset)), comment="Rearrange MI out reg"))" raise NotImplementedError

Sure!

[jayhawk-commits]

Please resolve merge conflicts or close this PR to complete the task of importing PRs from this repo to the monorepo.

[jayhawk-commits]

Please resolve merge conflicts or close this PR to complete the task of importing PRs from this repo to the monorepo.