amdsmi icon indicating copy to clipboard operation
amdsmi copied to clipboard

fix(python): fix comparison to True/False

Open e-kwsm opened this issue 1 year ago • 1 comments

from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):

Comparisons to singletons like None should always be done with is or is not, never the equality operators.

e-kwsm avatar May 31 '24 16:05 e-kwsm

Can you remove the rocm-smi.py changes? rocm-smi.py is a leftover from the rocm-smi project, and not intended to be changed independtly in this project. If you have any rocm-smi changes you can make them in https://github.com/ROCm/rocm_smi_lib. Otherwise the changes look good

marifamd avatar Sep 13 '24 17:09 marifamd