ROCm
fixed changes mentioned in review
[AMD Official Use Only - AMD Internal Distribution Only]
Let me expand a bit on the reproducible builds. It would be very nice if we could have two people, say in India and California, both starting a build on their local machines and end up with two sets of packages which are identical. There are lots of things that work against this, but we are tackling them. Obviously we want to start with the same source code. We get this by using the “repo” tool and a manifest which gets us the same files checked out in the same locations. We have a version controlled build environment, so we know we are using the same tools (compilers, shells, grep, make and so on). We know how to set timestamps embedded in files to uniform values, rather than the local time so this takes care of building in different time zones at different times. We would like any generated files whose names end up embedded in the product to be the same. This suggests that we should set HOME to a known value, and maybe LOGNAME and USER as well.
