rocAL - Warnings

[kiritigowda]

rocAL not tested on OCL Backend

• Multiple Warnings

In file included from ../../../../rocAL/rocAL/include/loaders/image/image_read_and_decode.h:28:
../../../../rocAL/rocAL/include/decoders/image/turbo_jpeg_decoder.h:60:10: warning: 'is_partial_decoder' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    bool is_partial_decoder() { return _is_partial_decoder; };
         ^
../../../../rocAL/rocAL/include/decoders/image/decoder.h:114:18: note: overridden virtual function is here
    virtual bool is_partial_decoder() = 0;
                 ^

• Run Tests

[kiritigowda]

• HIP Backend

/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp: In member function ‘virtual Decoder::Status FusedCropTJDecoder::decode(unsigned char*, size_t, unsigned char*, size_t, size_t, size_t, size_t, size_t&, size_t&, Decoder::ColorFormat, DecoderConfig, bool)’:
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp:144:30: warning: ‘y1’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  144 |     if( tjDecompress2_partial(m_jpegDecompressor,
      |         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
  145 |                       input_buffer,
      |                       ~~~~~~~~~~~~~
  146 |                       input_size,
      |                       ~~~~~~~~~~~
  147 |                       output_buffer,
      |                       ~~~~~~~~~~~~~~
  148 |                       max_decoded_width,
      |                       ~~~~~~~~~~~~~~~~~~
  149 |                       max_decoded_width * planes,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  150 |                       max_decoded_height,
      |                       ~~~~~~~~~~~~~~~~~~~
  151 |                       tjpf,
      |                       ~~~~~   
  152 |                       TJFLAG_FASTDCT, &x1_diff, &crop_width_diff,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  153 |                     x1, y1, crop_width, crop_height) != 0)
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp:166:33: warning: ‘x1’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  166 |         unsigned int xoffs = (x1-x1_diff) * planes;   // in case x1 gets adjusted by tjpeg decoder
      |                              ~~~^~~~~~~~~
[ 80%] Building CXX object rocAL/rocAL/CMakeFiles/rocal.dir/source/decoders/image/open_cv_decoder.cpp.o

[kiritigowda]

@LakshmiKumar23 let me know if OCL build is tested with TOT

[kiritigowda]

@LakshmiKumar23 can you please check these warnings

Ubuntu 22.04
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- rocAL -- Using HIP -- Path:/opt/rocm	Version:5.3.22374	Compiler:clang

/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/meta_data/bounding_box_graph.cpp: In member function ‘virtual void BoundingBoxGraph::update_box_encoder_meta_data(std::vector<float>*, pMetaDataBatch, float, bool, float, std::vector<float>&, std::vector<float>&)’:
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/meta_data/bounding_box_graph.cpp:145:15: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of non-trivially copyable type ‘BoundingBoxCord’ {aka ‘struct BoundingBoxCord_’}; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  145 |         memcpy(bb_coords, full_batch_meta_data->get_bb_cords_batch()[i].data(), full_batch_meta_data->get_bb_cords_batch()[i].size() * sizeof(BoundingBoxCord));
      |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/./include/meta_data/meta_data_graph.h:26,
                 from /home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/./include/meta_data/bounding_box_graph.h:25,
                 from /home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/source/meta_data/bounding_box_graph.cpp:22:
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/rocAL/rocAL/./include/meta_data/meta_data.h:37:16: note: ‘BoundingBoxCord’ {aka ‘struct BoundingBoxCord_’} declared here
   37 | typedef struct BoundingBoxCord_
      |                ^~~~~~~~~~~~~~~~

[kiritigowda]

#1013 fixes these warnings