MIVisionX icon indicating copy to clipboard operation
MIVisionX copied to clipboard

TurboJPEG - Push changes to upstream

Open kiritigowda opened this issue 2 years ago • 4 comments
trafficstars

rocAL requires a particular version of TurboJPEG which is only available on - git clone -b 2.0.6.1 https://github.com/rrawther/libjpeg-turbo.git

This is causing issues with DevOPS as they install TurboJPEG from publicly available release. Which fails with

/usr/bin/ld: /opt/rocm/lib/librocal.so: undefined reference to `tjDecompress2_partial_scale@TURBOJPEG_1.0'
/usr/bin/ld: /opt/rocm/lib/librocal.so: undefined reference to `tjDecompress2_partial@TURBOJPEG_1.0'
collect2: error: ld returned 1 exit status

To solve this we need to push the changes we require to upstream.

kiritigowda avatar Mar 15 '23 18:03 kiritigowda

@rrawther any updates on TurboJPEG?

kiritigowda avatar Jun 13 '23 23:06 kiritigowda

Hello @rrawther, I'm currently working on enabling rocAL for spack and I'm running into this error: error: 'tjDecompress2_partial_scale' was not declared in this scope             if( tjDecompress2_partial_scale(m_jpegDecompressor, I think the issue is because I'm using the publically available release of TurboJPEG. Are the changes for the partial decoder going to be pushed upstream anytime soon?

afzpatel avatar Aug 18 '23 14:08 afzpatel

Hi @afzpatel : To get rid of this, we need to do some work in the rocAL code so it doesn't use that API. Beause of no available resource to work on this, it is deferred. we will work on this in future.

rrawther avatar Aug 22 '23 18:08 rrawther

I've noticed a similar problem with rapidjson. rapidjson just needs a more up-to-date git version instead of release version, however with this we need an entire separate repo and version.

Madouura avatar Oct 11 '23 04:10 Madouura

TurboJPEG dependencies updated and rocAL moved out of MIVisionX as an independent component - https://github.com/ROCm/rocAL

kiritigowda avatar Mar 20 '24 14:03 kiritigowda