MISA icon indicating copy to clipboard operation
MISA copied to clipboard
verified publisher icon ROCm

Generate .amdhsa_reserve_xnack_mask 0 in all assembly kernels.

Open atamazov opened this issue 5 years ago • 4 comments

This will prevent rolling back changes from https://github.com/ROCmSoftwarePlatform/MIOpen/pull/505 when regenerating kernels.

/cc @daniellowell @shurale-nkn

atamazov avatar Oct 11 '20 20:10 atamazov

Hmm... Perhaps this is not really required, see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/505/files#r502967373

atamazov avatar Oct 11 '20 21:10 atamazov

Hi @atamazov it seems @shurale-nkn added that .amdhsa_reserve_xnack_mask in every asm kernel source code in MIOpen, however it still seems the xnack default value is target-dependent. Maybe I can add this directive while generate the kernels, but will generate different value of .amdhsa_reserve_xnack_mask based on target features. what do you think?

Ah, -mno-xnack compiler flag is still needed

carlushuang avatar Oct 12 '20 01:10 carlushuang

Most likely, this .amdhsa_reserve_xnack_mask 0 is not required in the generated kernels. The recent target-id related changes in the assembler looks weird. Let's see.

atamazov avatar Oct 12 '20 15:10 atamazov

OK

carlushuang avatar Oct 13 '20 00:10 carlushuang