HIPIFY icon indicating copy to clipboard operation
HIPIFY copied to clipboard

[HIPIFY][feature] Support for `fp8` data types

Open foreverlms opened this issue 1 year ago • 2 comments

Problem Description

Such as when I hipify a cu file having fp8 datatype in it, after the hipify-clang command, the fp8 datatype doesn't turned into HIP fp8 type.

For example:

__nv_fp8_e4m3

doesn't change and the hipify-clang will report error:

 error: unknown type name '__nv_fp8_e4m3'

Why? Doesn't hipify support FP8?

Operating System

Ubuntu 20.04.6 LTS (Focal Fossa)

CPU

AMD EPYC 7643 48-Core Processor

ROCm Version

ROCm 6.0.0

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

foreverlms avatar Aug 14 '24 06:08 foreverlms

Hello @foreverlms,

Currently, HIP supports some of the fp8 data types and APIs. Whereas, HIPIFY tools don't. Thank you for pointing it out.

Marking the ticket as a feature to Implement.

emankov avatar Aug 14 '24 12:08 emankov

Thanks for replying. Hope to see the fp8 support available.

foreverlms avatar Aug 15 '24 07:08 foreverlms

Finally implemented.

emankov avatar Nov 26 '24 19:11 emankov

Thanks for replying. Hope to see the fp8 support available.

Hi @foreverlms,

It is available now. Going to revise fp16 soon.

emankov avatar Nov 26 '24 19:11 emankov

Thanks for replying. Hope to see the fp8 support available.

Hi @foreverlms,

It is available now. Going to revise fp16 soon.

Thanks, this could be very helpful for mix300 series.

foreverlms avatar Nov 28 '24 02:11 foreverlms