HIP icon indicating copy to clipboard operation
HIP copied to clipboard

MathiasMagnus SAXPY and Reduction tutorial

Open neon60 opened this issue 1 year ago • 2 comments

The SAXPY and Reduction tutorial.

neon60 avatar May 17 '24 14:05 neon60

IMAGE OF FINAL ALGO is missing

neon60 avatar May 23 '24 11:05 neon60

IMAGE OF FINAL ALGO is missing

Fixed.

neon60 avatar May 27 '24 10:05 neon60

Added language suggestions from @lpaoletti. Review the diff if needed 2b4a8be

peterjunpark avatar Jun 05 '24 13:06 peterjunpark

@lpaoletti Can I get an approval?

neon60 avatar Jun 05 '24 14:06 neon60

The reduction tutorial PR: #3513

neon60 avatar Jun 05 '24 14:06 neon60

Should we remove the tab sync?

I don't like how the page jumps around when you select a tab due to the length of content changing all over the place at the same time.

peterjunpark avatar Jun 05 '24 15:06 peterjunpark

Should we remove the tab sync?

I don't like how the page jumps around when you select a tab due to content lengths changing everywhere at the same time.

Probably we should. I am thinking what we can do with it.

neon60 avatar Jun 05 '24 15:06 neon60

Should we remove the tab sync? I don't like how the page jumps around when you select a tab due to content lengths changing everywhere at the same time.

Probably we should. I am thinking what we can do with it.

I think we should keep it. I think a user is going to pick their flow in the first tab, and the page will update the content to display their flow. I don't think people will be flipping back and forth between flows except to see what differences there might be.

randyh62 avatar Jun 05 '24 15:06 randyh62

Looks good

Thanks for the review.

neon60 avatar Jun 25 '24 10:06 neon60