HIP icon indicating copy to clipboard operation
HIP copied to clipboard

Rename make_Complex() to make_hipComplex() in hip/nvidia_detail/nvidia_hip_complex.h

Open torrance opened this issue 1 year ago • 3 comments

In hip/nvidia_detail/nvidia_hip_complex.h, the function make_Complex() is incorrectly named.

It should be make_hipComplex() to be consistent with hip/amd_detail/nvidia_amd_complex.h as well as with HIPIFY.

torrance avatar May 11 '23 05:05 torrance

Thanks for pointing it out. Will fix it and should be available in future releases

jatinx avatar May 11 '23 14:05 jatinx

@jatinx Please advise if this has been fixed with latest ROCm 6.1.0 (HIP 6.1)? Thanks!

ppanchad-amd avatar Apr 25 '24 14:04 ppanchad-amd

In 6.1.0, it looks like make_Complex() has been renamed to make_hipFloatComplex(), alongside make_hipDoubleComplex().

torrance avatar May 01 '24 06:05 torrance