HIP icon indicating copy to clipboard operation
HIP copied to clipboard

EXSWHTEC-9 - Implement additional tests for hipIpcCloseMemHandle

Open mirza-halilcevic opened this issue 2 years ago • 2 comments

  • Verify that memory stays mapped when reference count is non zero
  • Verify that memory stays mapped if handle is closed in a second process
  • Verify that attempting to close handle in the process that created it causes an error.

mirza-halilcevic avatar Aug 23 '22 17:08 mirza-halilcevic

This won't build on Windows I believe.

@chrispaquot You're right. We added a Linux-only guard around the tests.

mirza-halilcevic avatar Sep 13 '22 07:09 mirza-halilcevic

This won't build on Windows I believe.

@chrispaquot You're right. We added a Linux-only guard around the tests.

Can't we just remove it from the Windows build?

chrispaquot avatar Sep 20 '22 20:09 chrispaquot

This won't build on Windows I believe.

@chrispaquot You're right. We added a Linux-only guard around the tests.

Can't we just remove it from the Windows build?

The test is now removed from the Windows build. Please proceed with the review.

mirza-halilcevic avatar Oct 03 '22 11:10 mirza-halilcevic

@mirza-halilcevic : Some tests fail CI. Details shared separately.

mangupta avatar Nov 03 '22 15:11 mangupta

@mirza-halilcevic : Some tests fail CI. Details shared separately.

PR updated, you can proceed with the merge.

mirza-halilcevic avatar Nov 04 '22 10:11 mirza-halilcevic