HIP icon indicating copy to clipboard operation
HIP copied to clipboard

Published 20 hours ago • verified publisher icon ROCm

Catch2 Unit Test Fixes

Open pvelesko opened this issue 3 years ago • 2 comments

  • Kernel launches are not being error checked. This can lead to cases where a failure in kernel invocation is classified as a failure in some other operation
  • hipLaunchKernelGGL does not return hipError_t so the check must be done via hipGetLastError
  • Block size of 512 exceeds the HW capabilities of some (integrated) GPUs
  • make_hipPitchedPtr is passed x, x, y as arguments instead of x, y, z

pvelesko avatar Jul 04 '22 12:07 pvelesko

Tagging @gargrahul as I forgot to mention this PR during our meeting.

Kerilk avatar Jul 07 '22 20:07 Kerilk

@mangupta done

pvelesko avatar Jul 11 '22 13:07 pvelesko

@mangupta

pvelesko avatar Aug 25 '22 07:08 pvelesko

@mangupta @Kerilk @gargrahul

pvelesko avatar Sep 15 '22 07:09 pvelesko

@pvelesko Could you please resubmit the required changes on top of the latest develop branch as a new PR ?

gargrahul avatar Sep 22 '22 16:09 gargrahul