roctracer README Outdated: Include File

This project's README is outdated with respect to the recommended include.

As of ROCm 5.2.0 on Crusher at least, I get the following warning when including <roctx.h>:

/opt/rocm-5.2.0/hip/../roctracer/include/roctx.h:26:9: warning: This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer [-W#pragma-messages]
#pragma message("This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer")
        ^

I assume the new include we should use is roctracer/roctx.h?

Likewise for #include <roctracer_ext.h> -> #include <roctracer/roctracer_ext.h>?

cc @arghdos

Sep 13 '22 22:09 ax3l

@frepaul -- is the new include path schema documented anywhere publicly?

Sep 14 '22 22:09 skyreflectedinmirrors

@ax3l -- I believe this is correct, but I am waiting on @frepaul who implemented this.

Sep 15 '22 13:09 skyreflectedinmirrors

@ax3l @arghdos : #pragma message is valid and requesting applications to change accordingly. Will work on updating the README as well, as we completely move away from the old method. Public info here: https://docs.amd.com/bundle/ROCm-Release-Notes-v5.2/page/Deprecations_and_Warnings.html

Sep 15 '22 17:09 frepaul

@ax3l Apologies for the lack of response. Can you please check with the latest ROCm 6.2 to see if this issue still occurs? If not, please close the ticket. Thanks!

Aug 15 '24 14:08 ppanchad-amd

@ax3l This should be fixed in commit https://github.com/ROCm/roctracer/commit/725d289a2b2ea551958cc3dc59d9ff59f7baf9f1. Closing the issue. Thanks!

Oct 07 '24 19:10 tcgu-amd