rocprofiler icon indicating copy to clipboard operation
rocprofiler copied to clipboard

Update env.cmake for consistency w/ CMakeLists

Open mhalk opened this issue 2 years ago • 2 comments

This NFC will only change the name of an internal variable. FIND_AQL_PROFILE_LIB to AQLPROFILE_LIB

However, this will increase consistency among three files:

  1. ./cmake_modules/env.cmake
  2. ./src/api/CMakeLists.txt
  • See: https://github.com/ROCm-Developer-Tools/rocprofiler/blob/rocm-5.5.x/src/api/CMakeLists.txt#L40-L42
  1. ./src/tools/rocprofv2/CMakeLists.txt
  • See: https://github.com/ROCm-Developer-Tools/rocprofiler/blob/rocm-5.5.x/src/tools/rocprofv2/CMakeLists.txt#L7-L8

Which in turn will enable an externally provided -DAQLPROFILE_LIB= to avoid a build termination.

mhalk avatar May 12 '23 15:05 mhalk

Hi @mhalk, I am in the process of reworking out cmake in general for the purposes of consistency and stability

jrmadsen avatar Aug 03 '23 22:08 jrmadsen

Great, thanks for letting me know. We had to patch around this, to avoid build failures -- so, generally looking forward!

mhalk avatar Aug 04 '23 18:08 mhalk