hipamd icon indicating copy to clipboard operation
hipamd copied to clipboard

[bug][5.3.x][NVIDIA] Nonexisting CUDA identifiers

Open emankov opened this issue 3 years ago • 1 comments

https://github.com/ROCm-Developer-Tools/hipamd/blob/develop/include/hip/nvidia_detail/nvidia_hip_runtime_api.h#L1056-L1058

#define hipGraphNodeTypeMemcpy1D cudaGraphNodeTypeMemcpy1D
#define hipGraphNodeTypeMemcpyFromSymbol cudaGraphNodeTypeMemcpyFromSymbol
#define hipGraphNodeTypeMemcpyToSymbol cudaGraphNodeTypeMemcpyToSymbol

emankov avatar May 11 '22 22:05 emankov

Update for ROCm HIP 5.3.0:

The following HIP-specific elements of the enum hipGraphNodeType don't have a correspondence in CUDA:

#define hipGraphNodeTypeMemcpyFromSymbol cudaGraphNodeTypeMemcpyFromSymbol
#define hipGraphNodeTypeMemcpyToSymbol cudaGraphNodeTypeMemcpyToSymbol

https://github.com/ROCm-Developer-Tools/hipamd/blob/develop/include/hip/nvidia_detail/nvidia_hip_runtime_api.h#L1145-L1146

cudaGraphNodeTypeMemcpyFromSymbol and cudaGraphNodeTypeMemcpyToSymbol are erroneous identifiers and the above defines must be eliminated.

emankov avatar Nov 01 '22 18:11 emankov