hipamd icon indicating copy to clipboard operation
hipamd copied to clipboard

RPATH is not optional

Open Mystro256 opened this issue 3 years ago • 2 comments

I noticed in 5.1.0, RPATH is not optional.

The commit in question is 58193bf238b290cd05980e0fffa2c56f8a3a3730

While I understand the rational from a ROCm packaging perspective, this causes issues for distros trying to package since RPATH is not optional.

Does this make sense to wrap this within the ROCM_RPATH condition later in the file?

Mystro256 avatar Apr 03 '22 15:04 Mystro256

Has there been any progress on resolving this issue?

The latest release version still runs into rpath problems due to the above commit. @agunashe what was the reason for adding those lines and can you come up with a proper solution to this issue?

awehrfritz avatar Aug 21 '22 20:08 awehrfritz

Hi @awehrfritz there's been some progress. A lot of the RPATH logic should be cleaned up for approximately the ROCm 5.5 release. It might make it into the next planned major release (5.4), but I'm not sure.

Mystro256 avatar Oct 31 '22 19:10 Mystro256