ROCclr icon indicating copy to clipboard operation
ROCclr copied to clipboard

Published 20 hours ago • verified publisher icon ROCm-Developer-Tools

Install export file so it is available for hip

Open pfultz2 opened this issue 4 years ago • 6 comments

This is necessary to build hip with rocclr.

pfultz2 avatar Jun 11 '20 18:06 pfultz2

Ping?

pfultz2 avatar Jun 16 '20 17:06 pfultz2

@pfultz2 looks good to me, but you need to push it to internal branch on Gerrit. +CC @gargrahul @mangupta

aaronenyeshi avatar Jun 16 '20 20:06 aaronenyeshi

The cmake logic had drastic changes recently. I believe the latest code has proper export already and it will be available in ROCM3.6.

gandryey avatar Jun 16 '20 20:06 gandryey

but you need to push it to internal branch on Gerrit.

I dont have access to push to that repo. Does this project not accept open source contributions?

pfultz2 avatar Jun 16 '20 21:06 pfultz2

but you need to push it to internal branch on Gerrit.

I dont have access to push to that repo. Does this project not accept open source contributions?

Are instructions available @ https://github.com/ROCm-Developer-Tools/HIP/issues/2104#issuecomment-643435845 not working for you ?

gargrahul avatar Jun 16 '20 21:06 gargrahul

Are instructions available @ ROCm-Developer-Tools/HIP#2104 (comment) not working for you ?

Those instructions of course do not work as they cannot be used by source-based package managers. This PR will fix the issue with the build scripts. I figured it would be more helpful to open a PR instead of an issue. Does rocclr not accept open source contributions?

pfultz2 avatar Jun 16 '20 22:06 pfultz2