dynamixel-workbench icon indicating copy to clipboard operation
dynamixel-workbench copied to clipboard

convertValue2Radian Not clear failure

Open yotabits opened this issue 2 years ago • 0 comments

https://github.com/ROBOTIS-GIT/dynamixel-workbench/blob/67a163199cab651fdf4aceb984f3b75ea30847fe/dynamixel_workbench_toolbox/src/dynamixel_workbench_toolbox/dynamixel_workbench.cpp#L1227

When the convertValue2Radian method has an error because mode_info is NULL it returns false or 0 which can also a be a valid motor position, I think it could be a good improvement to raise an error instead ! :)

yotabits avatar Oct 20 '22 07:10 yotabits