atbswp icon indicating copy to clipboard operation
atbswp copied to clipboard

Gui separation

Open WesleyMPG opened this issue 3 years ago • 8 comments

So, class naming first? What about PlayGui?

WesleyMPG avatar May 05 '21 14:05 WesleyMPG

Thanks for the PR, can you please rebase your work and apply your commits on top of the develop branch?

RMPR avatar May 07 '21 18:05 RMPR

So, class naming first? What about PlayGui?

You can also just swap the names, I think it still makes sense.

RMPR avatar May 08 '21 09:05 RMPR

Just found a bug in infinite playback with these changes. Steps to reproduce:

  • Record a capture
  • Enable infinite playback
  • Replay the capture
  • Click on the play button to stop (or press F10 the default shortcut)

Expected behaviour: The capture stops instantly or at least stops after the current iteration.

Observed behaviour: The capture keeps running forced to kill the process.

RMPR avatar May 08 '21 09:05 RMPR

Observed behaviour: The capture keeps running forced to kill the process.

That's weird. Here it's working fine:

WesleyMPG avatar May 08 '21 15:05 WesleyMPG

That's weird. Here it's working fine:

Try to record only the mouse and stop the playback with the keyboard (if you didn't change the default shortcut it's F10 iirc).

RMPR avatar May 08 '21 15:05 RMPR

In the meantime I implemented the event-based solution we discussed here gui-control

RMPR avatar May 08 '21 15:05 RMPR

In the meantime I implemented the event-based solution we discussed here

I'll check that.

WesleyMPG avatar May 08 '21 17:05 WesleyMPG

A rebase on top of develop would be great, I modified a bit the PlayCtrl, so you might have to solve merge issues.

RMPR avatar May 09 '21 18:05 RMPR