atbswp
atbswp copied to clipboard
Gui separation
So, class naming first? What about PlayGui?
Thanks for the PR, can you please rebase your work and apply your commits on top of the develop branch?
So, class naming first? What about PlayGui?
You can also just swap the names, I think it still makes sense.
Just found a bug in infinite playback with these changes. Steps to reproduce:
- Record a capture
- Enable infinite playback
- Replay the capture
- Click on the play button to stop (or press F10 the default shortcut)
Expected behaviour: The capture stops instantly or at least stops after the current iteration.
Observed behaviour: The capture keeps running forced to kill the process.
Observed behaviour: The capture keeps running forced to kill the process.
That's weird. Here it's working fine:
That's weird. Here it's working fine:
Try to record only the mouse and stop the playback with the keyboard (if you didn't change the default shortcut it's F10 iirc).
In the meantime I implemented the event-based solution we discussed here
In the meantime I implemented the event-based solution we discussed here
I'll check that.
A rebase on top of develop would be great, I modified a bit the PlayCtrl, so you might have to solve merge issues.