Rob Percival comments

Results 37 comments of


                                            Rob Percival

Stop copying parent attributes into child class

I think we'd want to tweak this so that the deprecated settings check still looks at inheriting settings, but otherwise it appears that this won't break any functionality. However, it...

If change import style elasticsearch mock fuctionality not working properly

I think if you used `patch.object(elasticsearch, "Elasticsearch", _get_elasticmock)` instead of `patch('elasticsearch.Elasticsearch', _get_elasticmock)` in the `elasticmock` decorator, that would fix this. This is probably the cause of #82 as well.

`rate_limit` limits other tasks in the queue as well

I raised this issue about a year ago: https://github.com/celery/celery/discussions/7803. I _think_ the solution is to increment the prefetch limit, as is done when a task with a future ETA is...

`rate_limit` limits other tasks in the queue as well

@auvipy, can I interpret you self-assigning this ticket to mean you're going to look into this? It'd be awesome to get this fixed 😁

`rate_limit` limits other tasks in the queue as well

@auvipy, as a sponsor, could I please request priority support on this? It's been over a year now with no progress.

Double asterisk in the ownership rule doesn't accept zero nesting

This is a pretty significant bug. Given that it hasn't been fixed in over a year, can I assume this plugin is abandoned? Is it worth me creating a PR...

Make `assert_all_requests_are_fired` always assert on exception

Hi @markstory, is there anything else you'd like updated on the PR, or are you now happy to approve it?