teleirc icon indicating copy to clipboard operation
teleirc copied to clipboard

Implement unit tests for telegram.go

Open Tjzabel opened this issue 5 years ago • 4 comments

Summary

Before we write unit tests for the main telegram.go file, we need to determine the method of testing that works best for the scope of this file.

Since telegram.go makes heavy use of external libraries and functionality, we need to have a way to properly mock all of these external calls so we can efficiently test the desired functionality.

Tjzabel avatar Apr 18 '20 20:04 Tjzabel

Discussed in 2020-05-23 meeting.


Release-blocking: No

@kennedy was interested in this work, and since it is not release-blocking, it is okay if this does not make it into the v2.0.0 release. We should revisit this issue in next week's meeting to figure out what next steps are here.

justwheel avatar May 23 '20 19:05 justwheel

  • Metadata edited:
    • Milestone (v2.x.x :arrow_right: v2.0.1)

justwheel avatar May 24 '20 16:05 justwheel

Discussed in 2020-11-01 IRC/Telegram meeting.


The testing sprint begins! I am taking this one on to get more familiar with the Telegram side of things and to get more comfortable with unit testing. Aiming for completion by end of sprint, 15 November.

justwheel avatar Nov 01 '20 17:11 justwheel

Discussed in 2020-11-15 meeting.


Blocked on #343. @Zedjones mentioned a NodeJS project that runs a local "mocked" Telegram API. We could potentially use this for something closer to integration testing. Since @Zedjones is already looking at GitHub Actions for migrating some of our CI and release automation processes into GitHub Actions, this issue is marked as blocked until the release automation issue is resolved.

See #343 for more info.

justwheel avatar Nov 16 '20 01:11 justwheel