sossoldi icon indicating copy to clipboard operation
sossoldi copied to clipboard

Added Empty State for Transaction List

Open uveshm003 opened this issue 9 months ago • 9 comments

Fix for #247

uveshm003 avatar Mar 15 '25 17:03 uveshm003

Hi, the PR doesn't actually reflect the figma file, you added in the homepage the widget that should show up only in the transactions page. See image below.

Figma PR
image photo_2025-03-16_14-48-28

lucaantonelli avatar Mar 16 '25 13:03 lucaantonelli

Okay my bad I will do the required changes

uveshm003 avatar Mar 16 '25 15:03 uveshm003

@theperu I have completed the changes you can review & Merge now.

uveshm003 avatar Mar 31 '25 17:03 uveshm003

@uveshm003 thanks we'll take a look at this in the next days

theperu avatar Mar 31 '25 17:03 theperu

@uveshm003 we have some high priority PRs that need to be merged first and then we will come back to you and the others. Unfortunately with the high activity of the project it's not easy to check everything in a short time

theperu avatar Apr 05 '25 10:04 theperu

@uveshm003 I didn't test the PR yet, but just by looking at the code, I can tell that u didn't make the changes that luca pointed here. I can see that you're still showing up the calculator images that is not as the Figma was intended to be.

So please request a review only and only if you made the changes requested

fres-sudo avatar Apr 06 '25 14:04 fres-sudo

Hey, The calculator image is only displayed in transactions screen not on home screen. I have used a Boolean variable to manage this. You can check the same.

uveshm003 avatar Apr 06 '25 14:04 uveshm003

Hey, The calculator image is only displayed in transactions screen not on home screen. I have used a Boolean variable to manage this. You can check the same.

You're right, my bad! I'll test it locally and give my feedback, sorry!

fres-sudo avatar Apr 06 '25 14:04 fres-sudo

Okay

uveshm003 avatar Apr 06 '25 14:04 uveshm003

Hi @uveshm003👋 We recently merged a PR that changed the folder structure, which caused some conflicts here. When you get a chance, could you take a look and resolve them?

If there’s no response in the next 15 days, we’ll consider this PR inactive and plan to close it to keep things tidy.

Thanks!

theperu avatar Aug 02 '25 10:08 theperu