clementine icon indicating copy to clipboard operation
clementine copied to clipboard

`ArmModeInstruction::DataProcessing` has redundancy in the fields

Open AlessioC31 opened this issue 2 years ago • 0 comments

pub enum ArmModeInstruction {
    DataProcessing {
        condition: Condition,
        alu_instruction: ArmModeAluInstruction,
        set_conditions: bool,
        op_kind: OperandKind,
        rn: u32,
        destination: u32,
        op2: AluSecondOperandInfo,
    },
...

We can remove op_kind since it encodes the information about whether the second op is register/immediate, but we already have this information in the op2 field

AlessioC31 avatar Feb 16 '23 13:02 AlessioC31