RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

Max. packet length for AT86RF2XX

Open PeterKietzmann opened this issue 10 years ago • 21 comments

EDIT: The issue was fixed with #3480. However, #3480 limits the maximum payload in a (transceiver-)packet, by keeping the theoretically maximum MAC-header length of 25 Bytes free. Ideally we want a dynamic solution that computes the actual MAC-header length (which may be shorter than 25 Bytes), to fill all packets with payload completely.

OLD: In ng_sixlowpan the max. packet size NETCONF_OPT_MAX_PACKET_SIZE is requested from the hardware device which correlates with the max. fragment size of a 6LoWPAN packet. It is the basis for 6LoWPAN fragmentation, if payloads are too long. In the art86rfxx netdev-driver the device returns the value NG_AT86RF2XX_MAX_PKT_LENGTH (127). In the drivers _send function it is checked if the transceivers max. packet length plus FCS check sequence plus 802.15.4 header length is greater than the transceivers max. fifo size. What I'm saying is: Shouldn't we return the max. packet size minus link layer header lengths to the 6LoWPAN fragmentation? Or do I get confused somewhere between fragmentation, header lengths and the transceivers fifo size?

PeterKietzmann avatar May 27 '15 10:05 PeterKietzmann

At least xbee seems to do it the way you describe it, so I guess you are right :D

miri64 avatar May 27 '15 10:05 miri64

For the record: #3480

PeterKietzmann avatar Jul 22 '15 21:07 PeterKietzmann

@OlegHahm I quickly adapted the issue-discription. Can you please read it and check if one understands the problem?

PeterKietzmann avatar Jul 23 '15 07:07 PeterKietzmann

I understand the edited problem statement.

jnohlgard avatar Jul 23 '15 07:07 jnohlgard

@PeterKietzmann, yes, I think it's comprehensible.

Btw. I discussed yesterday shortly with @authmillenon and we concluded that basically everything except the destination address length should be known to the link layer/transceiver driver.

OlegHahm avatar Jul 23 '15 07:07 OlegHahm

Among others, the function _make_data_frame_hdr checks for the header flags NG_NETIF_HDR_FLAGS_BROADCAST and/or NG_NETIF_HDR_FLAGS_MULTICAST. Is this known by the driver?

PeterKietzmann avatar Jul 23 '15 08:07 PeterKietzmann

@authmillenon, how is the situation in the new (netdev2) driver version?

OlegHahm avatar Feb 24 '16 19:02 OlegHahm

Nothing yet, but since netdev2 centralizes this, doing this should be quite easy.

miri64 avatar Feb 24 '16 20:02 miri64

But I would vote against doing it in #4646.

miri64 avatar Feb 24 '16 20:02 miri64

But I would vote against doing it in #4646.

Agreed!

OlegHahm avatar Feb 24 '16 20:02 OlegHahm

We leave this issue open until is fully solved?

kYc0o avatar Aug 04 '16 14:08 kYc0o

It's not solved yet, so yes ;-)

miri64 avatar Aug 04 '16 14:08 miri64

Again postponed.

miri64 avatar Oct 31 '16 09:10 miri64

Mhhh… this is more of an enhancement by now, not an issue => postponed.

miri64 avatar Nov 10 '16 15:11 miri64

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

stale[bot] avatar Aug 10 '19 06:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

stale[bot] avatar Feb 11 '20 09:02 stale[bot]

@jia200x might be of interest for you?

miri64 avatar Feb 11 '20 09:02 miri64

yes! Thanks!

jia200x avatar Feb 11 '20 12:02 jia200x

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

stale[bot] avatar Aug 14 '20 23:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

stale[bot] avatar Mar 19 '21 23:03 stale[bot]

ping?

maribu avatar Sep 16 '22 12:09 maribu

If I understand correctly this goes in the same direction as https://github.com/RIOT-OS/RIOT/issues/19132.

Normally, it is common procedure to close the new issues as duplicates of the old. In this case, I think the new issue is more general and this one a subset of the new issue. Hence, I'd like to close the old one here instead.

Please reopen if you disagree.

maribu avatar May 17 '23 15:05 maribu