sys/shell: always default to CONFIG_SHELL_SHUTDOWN_ON_EXIT=0

Open benpicco opened this issue 9 months ago • 3 comments

Contribution description

These days native is usually wrapped by pyterm. pyterm already takes care of handling ^D, so no need to handle this as a special case in native.

Testing procedure

examples/networking/misc/telnet_server no longer exits when you press ctrl-d on the remote shell.

Issues/PRs references

Mar 21 '25 18:03 benpicco

I'm not quite sure I understand the benefit of this PR. Does this fix or improve anything?

Mar 24 '25 16:03 OlegHahm

The only difference is for native with a remote shell. When the remote shell sends ^D it will now terminate the connection, but not exit the native process.

Jun 11 '25 14:06 benpicco

Murdock results

:heavy_check_mark: PASSED

8431d2ee4f394d3214780de587fa588e77344c24 sys/shell: always default to CONFIG_SHELL_SHUTDOWN_ON_EXIT=0

Success	Failures	Total	Runtime
10379	0	10379	12m:33s

Artifacts

Documentation preview

Jun 11 '25 15:06 riot-ci