RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

examples/gnrc_border_router: pass variables to docker

Open maribu opened this issue 1 year ago • 2 comments

Contribution description

This passes environment variables used to configure e.g. the uplink of the border router to the docker container, so that configuration works with BUILD_IN_DOCKER=1.

Testing procedure

Run:

USEMODULE="sock_dns gnrc_ipv6_nib_dns" make -C examples/gnrc_border_router BOARD=esp32-mh-et-live-minikit BUILD_IN_DOCKER=1 UPLINK=wifi WIFI_SSID=foobar WIFI_PASS=foobar1337 flash term
make: Entering directory '/home/maribu/Repos/software/RIOT/master/examples/gnrc_border_router'

In master, you'll see "crazy" serial output, as the build system on the host expects normal stdio and WiFi as uplink, but the build system in the docker container expected slip as uplink and multiplexes the uplink with stdio.

With this PR, the serial is no longer multiplexed with the uplink, but WiFi is used as configured.

Issues/PRs references

None

maribu avatar Apr 24 '24 16:04 maribu

Ahh, that makes sense :)

MrKevinWeiss avatar Apr 25 '24 08:04 MrKevinWeiss

Murdock results

:heavy_check_mark: PASSED

276ad186f2dd94cc4a09a66dfe02f29723f7b480 examples/gnrc_border_router: pass UPLINK etc to docker

Success Failures Total Runtime
10065 0 10066 20m:56s

Artifacts

riot-ci avatar Apr 25 '24 10:04 riot-ci