RIOT-OS
Microchip vendor files migration process
It is time again to upgrade our Microchip vendor files for our supported SAM0 devices. Unfortunately this time, things will be a little bit more trickier than before as Microchip decided to rework their vendor files:
- Support for structures bitfields dropped.
- Peripheral structures now utilize u8, u16, u32 registers instead of individual register structures (due to the drop of bitfields support).
- Peripherals structure were also renamed (At least they are no longer in camel case so they fit our coding convention yay!)
- Numerous small changes that will require tedious adjustments.
So why should we do it ? Because bug fixes, new silicon version added, but above all, to be able to add support for new families of microcontrollers from Microchip.
Migration plan:
- Option 1 Create a dedicated branch on RIOT-OS/RIOT repo, push all changes there kindly, and create a gigantic PR that will be ~~painful~~ funny to review. Obviously, this is something I'd like to avoid.
- Option 2:
Proceed by smaller steps across several releases even if it will increase the overall amount of work.
To do so, I propose the following steps:
- Eliminate all usage of bitfields in our codebase.
- Develop wrappers/macros to maintain backward compatibility for register access in all board and peripheral drivers (although this is not enjoyable).
- Introduce new vendor headers into
cpu/sam0_common/include/vendor_ng(these will NOT be included in compilation yet). - Gradually migrate each family to observe issues and address them diligently.
- Remove old vendor headers.
- Undo all changes related to register access modifications.
I am well aware, this will add significant amount of work but IMO, this is the price to pay to keep PR size reasonable. This will also prevent issue for people maintaining boards outside of the tree through EXTERNAL_BOARD_DIRS
For those curious about the changes, you will find all Microchip atpack here
Download the archive of any supported family, and compare the content of the include/ folder against cpu/sam0_common/include/vendor/XXXX
Obviously, all of this is debatable, and I'll take all ideas to reduce this burden.
After some thoughts, here is my proposal regarding this migration:
- [x] Remove all bitfields usage in our codebase (no more foo->bar.bit.xyz only foo->bar.reg)
- [ ] Creation of a new header for missing declarations
- [ ] Replace all single bit field using new declarations from the newly generated header (FOO_BAR_BITFIELD -> FOO_BAR_BITFIELD_Msk)
- [ ] Creation of a wrapper for register calls
- [ ] Make use of new wrapper in boards/ and cpu/
- [ ] Add a deprecation notice during build
- [ ] Add new Microchip vendor files under
cpu/sam0_common/include/vendor_ng - [ ] use AT BOARD LEVEL a new variable to switch to new headers
- [ ] Starting cleanup after one or two releases
Regarding step 2 & 3: These are mandatory because of the way Microchip build their new vendor files. Currently when the bitfield inside a register is more than 1 bit. We have
FOO_BAR_Pos
FOO_BAR_Msk
FOO_BAR(value)
This is the same AFAICT on new vendor files.
However, there is a difference when the bitfield is only one bit wide.
For example RTC_CTRLA_ENABLE (current header we have) is now spelled RTC_CTRLA_ENABLE_Msk on new vendor.
On new vendor files, Microchip decided to unify the use of _Msk for every bitfields.
This is why I propose to introduce a new header, which will be generated though a script.
The idea will be to parsed the current headers, look for both FOO_BAR_Pos and FOO_BAR_Msk. If both exist, we're good. If only _Pos exists, then generated a _Msk so we can match the behavior of the new vendor files.
Of course, this header will be dropped at the end of the migration process during the cleanup.
About the wrapper, I was thinking about something like
#if USE_MCHP_VENDOR_NG
#define REG(dev, offset) ((dev)->dev##_##offset)
#else
#define REG(dev, offset) ((dev)->offset.reg)
#endif
On new header, Microchip slightly change the new of every registers inside a peripheral.
For instance
RTC->CTRLA.reg (current header) should be use as RTC->RTC_CTRLA (on new header).
With the proposed macro, it will be REG(RTC, CTRLA)
I think such macro will allow us to avoid some pain.
Microchip is right in their decision to drop bitfields that is to much comfort. Changing bits should be a pain in the rear end with macros all over place.
The only positive thing about bitfield removal is that this might make more people aware that changing a bit often is a register read modify write ( and since they a usually marked volatile each bit modification has their own). But for that they would not need to also drop the structures just the mapping to addresses.
Changing bits should be a pain in the rear end with macros all over place.
Hopefully, all those macros will be there for a given time. This way, users will have time to adapt their out of the tree code. However, I am planning on cleaning up everything (and thus remove all macros) after one or two releases. So yeah, it will take time but in the end, it will look "as before".
maybe they just want to kill of c development by droping the wins of 15 year and go back to 1990s C
maybe they just want to kill of c development by droping the wins of 15 year and go back to 1990s C
I think, this is related to their recent migration to MPLABX and their will to unify SAM0 to PIC32. I've complained to them (through a ticket) about this. Especially doing this WITHOUT deprecation notice. They acknowledge the issue but they were like "it is what it is"