RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

tests/gnrc_ipv6_nib: rtr_ltime test

Open xnumad opened this issue 1 year ago • 3 comments

Contribution description

This PR only provides a test to verify that _handle_rtr_timeout does not have any effect on any RA options:

The Router Lifetime applies only to the router's usefulness as a default router; it does not apply to information contained in other message fields or options. Options that need time limits for their information include their own lifetime fields.

  • https://datatracker.ietf.org/doc/html/rfc4861

Emphasis added to highlight what part exactly this test covers. (In particular, it does not cover testing that the "Router Lifetime" has any effect to "the router's usefulness as a default router".)

Test is implemented as part of the "base test function", causing 4 tests to fail if not providing an implementation.

Issues/PRs references

Test is fulfilled by #20329 and #20371 (alone each, but they are also not mutually exclusive). While #20329 itself already provides tests, this PR is an additional test (so no duplicate tests across PRs or sth). (In fact, they do not seem to cover the code of that PR; they still succeed if only keeping the tests from the PR.)

xnumad avatar Feb 11 '24 22:02 xnumad

Murdock results

:heavy_check_mark: PASSED

38d5acf87b64f579f510cdfef4fb853014c4fddb tests/gnrc_ipv6_nib: rtr_ltime test

Success Failures Total Runtime
63 0 63 01m:36s

Artifacts

riot-ci avatar Feb 12 '24 10:02 riot-ci

Rebased, meaning PR can now be merged since test does not fail anymore since the code being tested was fixed (through merge of #20329)

xnumad avatar Jul 29 '24 18:07 xnumad

Force push: Modified commit: Adjusted for changes meanwhile made to master (via #20329)

xnumad avatar Jul 29 '24 18:07 xnumad